Skip to contentSkip to conversation

hwmon (ds1621): Remove detection function

PATCH Applied Robert Coulson 3 participants 5 messages May 23, 2013 – Jun 1, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 hwmon (ds1621): Remove detection function

Due to a lack of device and vendor identification registers, the Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes resulting in false positives. Therefore, the detection function is being removed in favor of explicit device instantiation.

---
 Documentation/hwmon/ds1621 |   25 +++++++++++------------
 drivers/hwmon/ds1621.c     |   48 --------------------------------------------
 2 files changed, 12 insertions(+), 61 deletions(-)

v2:
- removed detect function references in ds1621 documentation
- replaced deprecated with removed and fixed a spelling error v3:
- removed scanned addresses info, tables, and list

Documentation/hwmon/ds1621 +12 -13
index 140eab5..2022379 100644
@@ -4,24 +4,22 @@ Kernel driver ds1621
 Supported chips:
   * Dallas Semiconductor & Maxim Integrated DS1621
     Prefix: 'ds1621'
-    Addresses scanned: I2C 0x48 - 0x4f
+    Addresses scanned: none
     Datasheet: Publicly available from www.maximintegrated.com
 
   * Dallas Semiconductor DS1625
-    Prefix:
-     'ds1621' - if binding via _detect function
-     'ds1625' - explicit instantiation
-    Addresses scanned: I2C 0x48 - 0x4f
+    Prefix: 'ds1625'
+    Addresses scanned: none
     Datasheet: Publicly available from www.datasheetarchive.com
 
   * Maxim Integrated DS1631
     Prefix: 'ds1631'
-    Addresses scanned: I2C 0x48 - 0x4f
+    Addresses scanned: none
     Datasheet: Publicly available from www.maximintegrated.com
 
   * Maxim Integrated DS1721
     Prefix: 'ds1721'
-    Addresses scanned: I2C 0x48 - 0x4f
+    Addresses scanned: none
     Datasheet: Publicly available from www.maximintegrated.com
 
 Authors:
@@ -77,12 +75,13 @@ The DS1625 is pin compatible and functionally equivalent with the DS1621,
 but the DS1621 is meant to replace it. The DS1631 and DS1721 are also
 pin compatible with the DS1621, but provide multi-resolution support.
 
-Since there is no version register, there is no unique identification
-for these devices. In addition, the DS1631 and DS1721 will emulate a
-DS1621 device, if not explicitly instantiated (why? because the detect
-function compares the temperature register values bits and checks for a
-9-bit resolution). Therefore, for correct device identification and
-functionality, explicit device instantiation is required.
+Since there is no version or vendor identification register, there is
+no unique identification for these devices. Therefore, explicit device
+instantiation is required for correct device identification and functionality.
+
+And, for correct identification and operation, each device must be
+explicitly instantiated, one device per address, in this address
+range: 0x48..0x4f.
 
 The DS1721 is pin compatible with the DS1621, has an accuracy of +/- 1.0
 degree Celius over a -10 to +85 degree range, a minimum/maximum alarm
drivers/hwmon/ds1621.c +0 -48

66 lines not on this page · raw message

Signature · 7 lines
1.7.9.5


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Acked-by on v3 1/1
#1 lore raw

Hi Robert,

Quoted 11 lines · Robert Coulson

Due to a lack of device and vendor identification registers, the Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes resulting in false positives. Therefore, the detection function is being removed in favor of explicit device instantiation.

---
 Documentation/hwmon/ds1621 |   25 +++++++++++------------
 drivers/hwmon/ds1621.c     |   48 --------------------------------------------
 2 files changed, 12 insertions(+), 61 deletions(-)
Quoted 6 lines

v2:
- removed detect function references in ds1621 documentation
- replaced deprecated with removed and fixed a spelling error v3:
- removed scanned addresses info, tables, and list (...)

Thanks for the update, looks good to me.

Guenter, please pick and apply.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer Applied
#2 lore raw
In reply to Robert Coulson
Quoted 21 lines · Jean Delvare

Hi Robert,

Quoted 11 lines · Robert Coulson

Due to a lack of device and vendor identification registers, the Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes resulting in false positives. Therefore, the detection function is being removed in favor of explicit device instantiation.

---
 Documentation/hwmon/ds1621 |   25 +++++++++++------------
 drivers/hwmon/ds1621.c     |   48 --------------------------------------------
 2 files changed, 12 insertions(+), 61 deletions(-)
Quoted 6 lines

v2:
- removed detect function references in ds1621 documentation
- replaced deprecated with removed and fixed a spelling error v3:
- removed scanned addresses info, tables, and list (...)

Quoted 6 lines

Thanks for the update, looks good to me.

Guenter, please pick and apply.

Applied to -next.

Thanks a lot to both of you!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw
In reply to Robert Coulson

Hi Guenter,

Quoted 22 lines · Guenter Roeck
Quoted 21 lines · Jean Delvare

Hi Robert,

Quoted 17 lines · Robert Coulson

Due to a lack of device and vendor identification registers, the Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes resulting in false positives. Therefore, the detection function is being removed in favor of explicit device instantiation.

---
 Documentation/hwmon/ds1621 |   25 +++++++++++------------
 drivers/hwmon/ds1621.c     |   48 --------------------------------------------
 2 files changed, 12 insertions(+), 61 deletions(-)

v2:
- removed detect function references in ds1621 documentation
- replaced deprecated with removed and fixed a spelling error v3:
- removed scanned addresses info, tables, and list (...)

Quoted 7 lines
Quoted 5 lines

Thanks for the update, looks good to me.

Guenter, please pick and apply.

Applied to -next.

Was this patch lost somehow? I can't see it in your tree.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer
#4 lore raw
In reply to Robert Coulson
Quoted 27 lines · Jean Delvare

Hi Guenter,

Quoted 24 lines · Guenter Roeck
Quoted 23 lines · Jean Delvare

Hi Robert,

Quoted 11 lines · Robert Coulson

Due to a lack of device and vendor identification registers, the Dallas/Maxim DS16xx devices cannot be uniquely detected, sometimes resulting in false positives. Therefore, the detection function is being removed in favor of explicit device instantiation.

---
 Documentation/hwmon/ds1621 |   25 +++++++++++------------
 drivers/hwmon/ds1621.c     |   48 --------------------------------------------
 2 files changed, 12 insertions(+), 61 deletions(-)
Quoted 6 lines

v2:
- removed detect function references in ds1621 documentation
- replaced deprecated with removed and fixed a spelling error v3:
- removed scanned addresses info, tables, and list (...)

Thanks for the update, looks good to me.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Guenter, please pick and apply.

Applied to -next.

Was this patch lost somehow? I can't see it in your tree.

Usually I keep it local for a day or two to ensure it passes nightly testing. In this case, I simply forgot to push the branch into the upstream repo. Too much work last week, sorry. It is now available.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors