Skip to contentSkip to conversation

ARM: dts: Correct the base address of pinctrl_3 on Exynos5250

PATCH RESEND Applied Padmavathi Venna 4 participants 6 messages Jun 12, 2013 – Jun 17, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 ARM: dts: Correct the base address of pinctrl_3 on Exynos5250

This patch corrects the base address of pinctrl_3 on Exynos5250 platform.

---
Changes since V1:
- Added platform name in the subject line.

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    2 +-
 arch/arm/boot/dts/exynos5250.dtsi         |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +1 -1
index d1650fb..ded558b 100644
@@ -763,7 +763,7 @@
 		};
 	};
 
-	pinctrl@03680000 {
+	pinctrl@03860000 {
 		gpz: gpz {
 			gpio-controller;
 			#gpio-cells = <2>;
arch/arm/boot/dts/exynos5250.dtsi +2 -2
index 7154e3d..e9bfd13 100644
@@ -169,9 +169,9 @@
 		interrupts = <0 50 0>;
 	};
 
-	pinctrl_3: pinctrl@03680000 {
+	pinctrl_3: pinctrl@03860000 {
 		compatible = "samsung,exynos5250-pinctrl";
-		reg = <0x0368000 0x1000>;
+		reg = <0x03860000 0x1000>;
 		interrupts = <0 47 0>;
 	};
 
Signature · 1 line
1.7.4.4

A message that is not in the archive (sent off-list or not yet received): 1371025425-480-1-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org

#2 lore raw

PATCH RESEND v2 1/1 ARM: dts: wm8994: Add wm8994 regulator support on smdk5250.

This patch adds the required regulator supplies and properties for wm8994 codec on smdk5250 board.

---

Changes since V1:
- Clubbed the same supply regulators as suggested by Mark.

 arch/arm/boot/dts/exynos5250-smdk5250.dts |   37 +++++++++++++++++++++++++++-
 1 files changed, 35 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +35 -2
index f2a025e..dc2ec25 100644
@@ -37,6 +37,30 @@
 		};
 	};
 
+	vdd:fixed-regulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd-supply";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+	};
+
+	dbvdd:fixed-regulator@1 {
+		compatible = "regulator-fixed";
+		regulator-name = "dbvdd-supply";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	spkvdd:fixed-regulator@2 {
+		compatible = "regulator-fixed";
+		regulator-name = "spkvdd-supply";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
 	i2c@12C70000 {
 		samsung,i2c-sda-delay = <100>;
 		samsung,i2c-max-bus-freq = <20000>;
@@ -47,8 +71,17 @@
 		};
 
 		wm8994: wm8994@1a {
-			 compatible = "wlf,wm8994";
-			 reg = <0x1a>;
+			compatible = "wlf,wm8994";
+			reg = <0x1a>;
+
+			gpio-controller;
+			#gpio-cells = <2>;
+
+			AVDD2-supply = <&vdd>;
+			CPVDD-supply = <&vdd>;
+			DBVDD-supply = <&dbvdd>;
+			SPKVDD1-supply = <&spkvdd>;
+			SPKVDD2-supply = <&spkvdd>;
 		};
 	};
 
Signature · 1 line
1.7.4.4
Applied
#3 lore raw

RE: [PATCH RESEND V2] ARM: dts: wm8994: Add wm8994 regulator support on smdk5250.

Quoted 10 lines · Padmavathi Venna

This patch adds the required regulator supplies and properties for wm8994 codec on smdk5250 board.

---

Changes since V1:
- Clubbed the same supply regulators as suggested by Mark.

Applied, thanks.

- Kukjin

Applied
#4 lore raw
In reply to Padmavathi Venna
Quoted 45 lines · Padmavathi Venna

This patch corrects the base address of pinctrl_3 on Exynos5250 platform.

---
Changes since V1:
- Added platform name in the subject line.

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    2 +-
 arch/arm/boot/dts/exynos5250.dtsi         |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +1 -1
index d1650fb..ded558b 100644
@@ -763,7 +763,7 @@
 		};
 	};
 
-	pinctrl@03680000 {
+	pinctrl@03860000 {
 		gpz: gpz {
 			gpio-controller;
 			#gpio-cells = <2>;
arch/arm/boot/dts/exynos5250.dtsi +2 -3
index 7154e3d..e9bfd13 100644
@@ -169,9 +169,9 @@
 		interrupts = <0 50 0>;
 	};
 
-	pinctrl_3: pinctrl@03680000 {
+	pinctrl_3: pinctrl@03860000 {
 		compatible = "samsung,exynos5250-pinctrl";
-		reg = <0x0368000 0x1000>;
+		reg = <0x03860000 0x1000>;
 		interrupts = <0 47 0>;
 	};
 
--
Quoted 1 line

1.7.4.4

Yes, right.

Thanks, applied.

- Kukjin

Acked-by on v2 1/1
#5 lore raw
In reply to Padmavathi Venna
Quoted 5 lines · Padmavathi Venna

This patch corrects the base address of pinctrl_3 on Exynos5250 platform.

(+ Olof)

Olof, there is no other fixes in my tree for v3.10 yet, so would be helpful if you could take this into fixes in arm-soc for v3.10. Just note, the wrong address added during v3.10 merge window.

If you want,

If any problems, please kindly let me know.

Thanks,
- Kukjin

Quoted 41 lines

---
Changes since V1:
- Added platform name in the subject line.

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    2 +-
 arch/arm/boot/dts/exynos5250.dtsi         |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +1 -1
index d1650fb..ded558b 100644
@@ -763,7 +763,7 @@
 		};
 	};
 
-	pinctrl@03680000 {
+	pinctrl@03860000 {
 		gpz: gpz {
 			gpio-controller;
 			#gpio-cells = <2>;
arch/arm/boot/dts/exynos5250.dtsi +2 -3
index 7154e3d..e9bfd13 100644
@@ -169,9 +169,9 @@
 		interrupts = <0 50 0>;
 	};
 
-	pinctrl_3: pinctrl@03680000 {
+	pinctrl_3: pinctrl@03860000 {
 		compatible = "samsung,exynos5250-pinctrl";
-		reg = <0x0368000 0x1000>;
+		reg = <0x03860000 0x1000>;
 		interrupts = <0 47 0>;
 	};
 
--

1.7.4.4

#6 lore raw
Quoted 5 lines · Kukjin Kim
Quoted 4 lines · Padmavathi Venna

This patch corrects the base address of pinctrl_3 on Exynos5250 platform.

Quoted 7 lines
Quoted 1 line

(+ Olof)

Olof, there is no other fixes in my tree for v3.10 yet, so would be helpful if you could take this into fixes in arm-soc for v3.10. Just note, the wrong address added during v3.10 merge window.

Huh. I guess we lucked out on snow since we're definitely using this and didn't hit any problems from it.

I'll apply to fixes.

-Olof