Skip to contentSkip to conversation

tpm: tpm_i2c_infinion: Don't modify i2c_client->driver

PATCH In review Lars-Peter Clausen 2 participants 2 messages Jun 15, 2013 – Jun 23, 2013 TPM device driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm: tpm_i2c_infinion: Don't modify i2c_client->driver

The I2C client driver is not supposed to modify the client's driver pointer, this is handled by the I2C core.

---
 drivers/char/tpm/tpm_i2c_infineon.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/char/tpm/tpm_i2c_infineon.c +0 -3
index 37d5dcc..dbc7042 100644
@@ -74,7 +74,6 @@ struct tpm_inf_dev {
 };
 
 static struct tpm_inf_dev tpm_dev;
-static struct i2c_driver tpm_tis_i2c_driver;
 
 /*
  * iic_tpm_read() - read from TPM register
@@ -744,11 +743,9 @@ static int tpm_tis_i2c_probe(struct i2c_client *client,
 		return -ENODEV;
 	}
 
-	client->driver = &tpm_tis_i2c_driver;
 	tpm_dev.client = client;
 	rc = tpm_tis_i2c_init(&client->dev);
 	if (rc != 0) {
-		client->driver = NULL;
 		tpm_dev.client = NULL;
 		rc = -ENODEV;
 	}
Signature · 1 line
1.8.0