tpm: tpm_i2c_infinion: Don't modify i2c_client->driver
PATCH 1/1 tpm: tpm_i2c_infinion: Don't modify i2c_client->driver
The I2C client driver is not supposed to modify the client's driver pointer, this is handled by the I2C core.
Signed-off-by Lars-Peter Clausen <[email protected]>
--- drivers/char/tpm/tpm_i2c_infineon.c | 3 --- 1 file changed, 3 deletions(-)
drivers/char/tpm/tpm_i2c_infineon.c +0 -3
@@ -74,7 +74,6 @@ struct tpm_inf_dev { };static struct tpm_inf_dev tpm_dev; -static struct i2c_driver tpm_tis_i2c_driver;/* * iic_tpm_read() - read from TPM register
@@ -744,11 +743,9 @@ static int tpm_tis_i2c_probe(struct i2c_client *client,return -ENODEV ; } - client->driver = &tpm_tis_i2c_driver; tpm_dev.client = client; rc =tpm_tis_i2c_init (&client->dev);if (rc !=0 ) { - client->driver =NULL ; tpm_dev.client =NULL ; rc = -ENODEV ; }
Signature · 1 line
1.8.0
Peter Hüwe
maintainerAm Samstag, 15. Juni 2013, 16:23:24 schrieb Lars-Peter Clausen:
Quoted 5 lines
The I2C client driver is not supposed to modify the client's driver pointer, this is handled by the I2C core.
Signed-off-by Lars-Peter Clausen <[email protected]>---
Nice catch.
Staged here:
https://github.com/PeterHuewe/linux-tpmdd/commits/for-james
Thanks,
Peter