Skip to contentSkip to conversation

rsxx: Moving pci_map_page to prevent overflow.

PATCH In review Philip J. Kelleher 2 participants 2 messages Sep 4, 2013 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH v3 2/2 rsxx: Moving pci_map_page to prevent overflow.

From: Philip J Kelleher <[email protected]>

The pci_map_page function has been moved into our issued workqueue to prevent an us running out of mappable addresses on non-HWWD PCIe x8 slots. The maximum amount that can possible be mapped at one time now is: 255 dmas X 4 dma channels X 4096 Bytes.

-------------------------------------------------------------------------------

drivers/block/rsxx/core.c +0 -5
diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/core.c linux-block/drivers/block/rsxx/core.c
@@ -749,10 +749,6 @@ static pci_ers_result_t rsxx_slot_reset(
 
 	card->eeh_state = 0;
 
-	st = rsxx_eeh_remap_dmas(card);
-	if (st)
-		goto failed_remap_dmas;
-
 	spin_lock_irqsave(&card->irq_lock, flags);
 	if (card->n_targets & RSXX_MAX_TARGETS)
 		rsxx_enable_ier_and_isr(card, CR_INTR_ALL_G);
@@ -779,7 +775,6 @@ static pci_ers_result_t rsxx_slot_reset(
 	return PCI_ERS_RESULT_RECOVERED;
 
 failed_hw_buffers_init:
-failed_remap_dmas:
 	for (i = 0; i < card->n_targets; i++) {
 		if (card->ctrl[i].status.buf)
 			pci_free_consistent(card->dev,
drivers/block/rsxx/dma.c +28 -42

106 lines not on this page · raw message

Reviewed-by on v3 2/2
#1 lore raw
Quoted 9 lines · Philip J. Kelleher

From: Philip J Kelleher <[email protected]>

The pci_map_page function has been moved into our issued workqueue to prevent an us running out of mappable addresses on non-HWWD PCIe x8 slots. The maximum amount that can possible be mapped at one time now is: 255 dmas X 4 dma channels X 4096 Bytes.

Signature · 3 lines
Brian King
Power Linux I/O
IBM Linux Technology Center