Skip to content

rsxx: RSXX driver Bug fixes.

Philip J. Kelleher lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rsxx: Handling failed pci_map_page on PowerPC and double free.drivers/block/rsxx/core.c drivers/block/rsxx/dma.c drivers/block/rsxx/rsxx_priv.h+37 -221 reply
2/2rsxx: Moving pci_map_page to prevent overflow.drivers/block/rsxx/core.c drivers/block/rsxx/dma.c+28 -471 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBrian King
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] rsxx: RSXX driver Bug fixes.

The incoming patch series contains 2 patches for the rsxx driver (drivers/block/rsxx).

Version 1:
A patch series containing 5 patches was sent out a few weeks ago.

Version 2:
o This version decreased the number of patches for the patch series based on importance.
o Started using the function pci_dma_mapping_error to check the return status of pci_map_page.

Version 3:
o Fixes a compile error in patch 1.
o Changed the error handling for pci_map_page
to cancel all dmas instead of just returning
out.

Patch 1:
The driver wasn't handling the return value of pci_map_page correctly for the PowerPC architecture. This also uncovered a double free scenario that is fixed here.

Patch 2:
In this patch, the pci_map_page function has been moved into our issued workqueue to prevent an us running out of mappable addresses on non- HWWD PCIe x8 slots. The maximum amount that can possible be mapped at one time now is:
255 dmas X 4 dma channels X 4096 Bytes.

Regards,
- Philip Kelleher