Skip to contentSkip to conversation

at91: add support for CDU9G25 board

PATCH New Jiri Prchal 2 participants 2 messages Sep 6, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 at91: add support for CDU9G25 board

This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

---
 board/cdu9g25/Makefile    |   48 ++++++++++
 board/cdu9g25/cdu9g25.c   |  129 +++++++++++++++++++++++++++
 board/cdu9g25/config.mk   |    1 +
 boards.cfg                |    1 +
 include/configs/cdu9g25.h |  217 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 396 insertions(+)
 create mode 100644 board/cdu9g25/Makefile
 create mode 100644 board/cdu9g25/cdu9g25.c
 create mode 100644 board/cdu9g25/config.mk
 create mode 100644 include/configs/cdu9g25.h
board/cdu9g25/Makefile new file +48 -0
new file mode 100644
index 0000000..11e2d4f
@@ -0,0 +1,48 @@
+#
+# (C) Copyright 2003-2008
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# (C) Copyright 2008
+# Stelian Pop <[email protected]>
+# Lead Tech Design <www.leadtechdesign.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS-y	+= cdu9g25.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS-y))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/cdu9g25/cdu9g25.c new file +129 -0

129 lines not on this page · raw message

board/cdu9g25/config.mk new file +1 -0
new file mode 100644
index 0000000..528ed4a
@@ -0,0 +1 @@
+CONFIG_SYS_TEXT_BASE = 0x27f00000
boards.cfg +1 -0
index be810c7..572d20d 100644
@@ -77,6 +77,7 @@ integratorcp_cm926ejs        arm         arm926ejs   integrator          armltd
 aspenite                     arm         arm926ejs   -                   Marvell        armada100
 gplugd                       arm         arm926ejs   -                   Marvell        armada100
 afeb9260                     arm         arm926ejs   -                   -              at91
+cdu9g25                      arm         arm926ejs   -                   -              at91
 at91sam9260ek_dataflash_cs0  arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS0
 at91sam9260ek_dataflash_cs1  arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_DATAFLASH_CS1
 at91sam9260ek_nandflash      arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9260,SYS_USE_NANDFLASH
include/configs/cdu9g25.h new file +217 -0

217 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 at91: add support for CDU9G25 board

Dear Jiri Prchal,

Quoted 14 lines · In message <[email protected]> you…

This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

---
 board/cdu9g25/Makefile    |   48 ++++++++++
 board/cdu9g25/cdu9g25.c   |  129 +++++++++++++++++++++++++++
 board/cdu9g25/config.mk   |    1 +
 boards.cfg                |    1 +
 include/configs/cdu9g25.h |  217 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 396 insertions(+)
 create mode 100644 board/cdu9g25/Makefile
 create mode 100644 board/cdu9g25/cdu9g25.c
 create mode 100644 board/cdu9g25/config.mk
 create mode 100644 include/configs/cdu9g25.h

Entry to MAINTAINERS file missing.

Also, there is a large number of checkpatch warnings that need to be fixed:

WARNING: please, no spaces at the start of a line
WARNING: space prohibited between function name and open parenthesis '('
ERROR: do not use C99 // comments
WARNING: line over 80 characters

Quoted 20 lines
include/configs/cdu9g25.h new file +14 -0
new file mode 100644
index 0000000..f8f8008
@@ -0,0 +1,217 @@
+/*
+ * (C) Copyright 2007-2008
+ * Stelian Pop <[email protected]>
+ * Lead Tech Design <www.leadtechdesign.com>
+ *
+ * Configuation settings for the CDUNG boards.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.

include/configs/cdu9g25.h line 24

Quoted 10 lines
include/configs/cdu9g25.h new file +10 -0
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA

Please use SPDX ID string here.

include/configs/cdu9g25.h line 74

Quoted 2 lines
include/configs/cdu9g25.h new file +2 -0
+#define CONFIG_HW_WATCHDOG		1
+#define CONFIG_AT91SAM9_WATCHDOG	1

Please remove values from all logical variables.

include/configs/cdu9g25.h line 196

Quoted 4 lines
include/configs/cdu9g25.h new file +4 -0
+#define CONFIG_BOOTARGS			"console=ttyS0,115200 ubi.mtd=root root=ubi0:root rootfstype=ubifs rw g_ether.dev_addr=02:04:25:aa:55:5e g_ether.host_addr=02:04:25:aa:55:5f"
+#define CONFIG_ETHADDR			02:04:de:ad:be:ef
+#define CONFIG_IPADDR			10.0.1.2
+#define CONFIG_SERVERIP			10.0.1.1

NAK. We don't allow any such kind of static network initialization which would be common for all boards. Please remove all of these.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There was no difference between  the  behavior  of  a  god  and  the
operations of pure chance..."   - Thomas Pynchon, _Gravity's Rainbow_