Skip to contentSkip to conversation

mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

PATCH New Ezequiel Garcia 3 participants 5 messages Sep 11, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix this build error (with pxa3xx_defconfig or similar):

drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration]

Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Kevin Hilman <[email protected]>
---
 drivers/mtd/nand/pxa3xx_nand.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/mtd/nand/pxa3xx_nand.c +6 -0
index 5db900d..240a239 100644
@@ -1289,6 +1289,12 @@ static inline int pxa3xx_nand_probe_dt(struct platform_device *pdev)
 {
 	return 0;
 }
+
+static inline enum pxa3xx_nand_variant
+pxa3xx_nand_get_variant(struct platform_device *pdev)
+{
+	return PXA3XX_NAND_VARIANT_PXA;
+}
 #endif
 
 static int pxa3xx_nand_probe(struct platform_device *pdev)
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

Quoted 11 lines · Ezequiel Garcia

This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix this build error (with pxa3xx_defconfig or similar):

drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration]

Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Kevin Hilman <[email protected]>

Nack. This has already been fixed by you(!), Brian is just sitting on the patch and not sending it up for some reason. Brian?

-Olof

#2 lore raw

PATCH 1/1 mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

Quoted 8 lines · Olof Johansson
Quoted 6 lines · Ezequiel Garcia

This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix this build error (with pxa3xx_defconfig or similar):

drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration]

Quoted 8 lines
Quoted 5 lines
Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Kevin Hilman <[email protected]>

Nack. This has already been fixed by you(!), Brian is just sitting on the patch and not sending it up for some reason. Brian?

First, Ezequiel, please CC linux-mtd when you send MTD patches. This didn't show up in my Maintainer inbox because I'm not an ARM maintainer (but you *did* CC their list) :)

Second, David hasn't authorized me to send pull requests, so I'm just queueing things up for him. I don't know why David removed this patch (among a few others) from his pull request.

David, the following commit (currently in l2-mtd.git) was a dependency for the rest of the pxa3xx series you just sent upstream. You (inadvertently?) left it out when you rebased. Please send a pull request for 3.12-rcX with at least this patch:

commit c4287efe67c298b1304c613093371103ac1bbb98

Author: Ezequiel Garcia <[email protected]>
Date:   Mon Aug 12 14:14:46 2013 -0300

mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF

There's no need to enclose this code within idef CONFIG_OF, because the OF framework provides no-op stubs if CONFIG_OF=n.

Cc devicetree at vger.kernel.org

Brian

#3 lore raw

PATCH 1/1 mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

Quoted 15 lines · Brian Norris
Quoted 14 lines · Olof Johansson
Quoted 11 lines · Ezequiel Garcia

This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix this build error (with pxa3xx_defconfig or similar):

drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration]

Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Kevin Hilman <[email protected]>
Quoted 7 lines
Quoted 2 lines

Nack. This has already been fixed by you(!), Brian is just sitting on the patch and not sending it up for some reason. Brian?

First, Ezequiel, please CC linux-mtd when you send MTD patches. This didn't show up in my Maintainer inbox because I'm not an ARM maintainer (but you *did* CC their list) :)

Argh! Sorry about that. I cooked the above one in a rush.

Quoted 4 lines

Second, David hasn't authorized me to send pull requests, so I'm just queueing things up for him. I don't know why David removed this patch (among a few others) from his pull request.

As you may recall, we did the below patch because you (correctly) noticed it was possible to avoid the ifdef. It also fixed the build break, but nobody noticed that until just now, so nobody reported the patch was actually a fix.

So, I guess David considered it was a less urgent fix and decided to postpone it.

Quoted 18 lines

David, the following commit (currently in l2-mtd.git) was a dependency for the rest of the pxa3xx series you just sent upstream. You (inadvertently?) left it out when you rebased. Please send a pull request for 3.12-rcX with at least this patch:

commit c4287efe67c298b1304c613093371103ac1bbb98

Author: Ezequiel Garcia <[email protected]>
Date:   Mon Aug 12 14:14:46 2013 -0300

mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF

There's no need to enclose this code within idef CONFIG_OF, because the OF framework provides no-op stubs if CONFIG_OF=n.

Cc devicetree at vger.kernel.org
Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 mtd: nand: pxa3xx: Add pxa3xx_nand_get_variant() stub for !CONFIG_OF

Quoted 18 lines · Ezequiel Garcia
Quoted 17 lines · Brian Norris
Quoted 16 lines · Olof Johansson
Quoted 11 lines · Ezequiel Garcia

This commit adds a dummy pxa3xx_nand_get_variant() stub, to fix this build error (with pxa3xx_defconfig or similar):

drivers/mtd/nand/pxa3xx_nand.c:1325:2: error: implicit declaration of function 'pxa3xx_nand_get_variant' [-Werror=implicit-function-declaration]

Cc Brian Norris <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Kevin Hilman <[email protected]>

Nack. This has already been fixed by you(!), Brian is just sitting on the patch and not sending it up for some reason. Brian?

...

Quoted 7 lines
Quoted 3 lines

Second, David hasn't authorized me to send pull requests, so I'm just queueing things up for him. I don't know why David removed this patch (among a few others) from his pull request.

As you may recall, we did the below patch because you (correctly) noticed it was possible to avoid the ifdef. It also fixed the build break, but nobody noticed that until just now, so nobody reported the patch was actually a fix.

Well, your series originally defined this stub function before I recommended a change to drop the CONFIG_OF check. See your v2 patch:

http://lists.infradead.org/pipermail/linux-mtd/2013-August/047863.html

So there never was a build breakage until David rebased; the patch was just a dependent part of the series that should never have been postponed.

Brian