qdisc: basic classifier - remove unnecessary initialization
Subsystems (3)
PATCH 1/1 qdisc: basic classifier - remove unnecessary initialization
err is set once, then first code resets it.
err = tcf_exts_validate(...)
Signed-off-by Stephen Hemminger <[email protected]>
net/sched/cls_basic.c +1 -1
@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *nstruct nlattr **tb, struct nlattr *est) { - int err = -EINVAL; + int err;struct tcf_exts e;struct tcf_ematch_tree t;
Quoted 9 lines · Stephen Hemminger
err is set once, then first code resets it.
err =tcf_exts_validate(...)Signed-off-by Stephen Hemminger <[email protected]>
net/sched/cls_basic.c static int basic_set_parms(struct net *n · line 143
Quoted 8 lines
net/sched/cls_basic.c +1
-1@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *nstruct nlattr **tb, struct nlattr *est) { - int err = -EINVAL; + int err;struct tcf_exts e;struct tcf_ematch_tree t;
Acked-by Jamal Hadi Salim <[email protected]>
cheers,
jamal
From: Stephen Hemminger <[email protected]>
Date: Thu, 26 Sep 2013 17:42:16 -0700
Quoted 4 lines
err is set once, then first code resets it.
err =tcf_exts_validate(...)Signed-off-by Stephen Hemminger <[email protected]>
Applied.