Skip to contentSkip to conversation

qdisc: basic classifier - remove unnecessary initialization

PATCH Applied Stephen Hemminger 3 participants 3 messages Sep 27, 2013 – Sep 30, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qdisc: basic classifier - remove unnecessary initialization

err is set once, then first code resets it.
err = tcf_exts_validate(...)

net/sched/cls_basic.c +1 -1
@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
 			   struct nlattr **tb,
 			   struct nlattr *est)
 {
-	int err = -EINVAL;
+	int err;
 	struct tcf_exts e;
 	struct tcf_ematch_tree t;
 
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Stephen Hemminger

err is set once, then first code resets it.
err = tcf_exts_validate(...)

net/sched/cls_basic.c static int basic_set_parms(struct net *n · line 143

Quoted 8 lines
net/sched/cls_basic.c +1 -1
@@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
  			   struct nlattr **tb,
  			   struct nlattr *est)
  {
-	int err = -EINVAL;
+	int err;
  	struct tcf_exts e;
  	struct tcf_ematch_tree t;
 

cheers,
jamal