Skip to contentSkip to conversation

Add Core Divider clock support for Armada 370/XP

PATCH New Ezequiel Garcia 3 participants 15 messages Sep 26, 2013 – Nov 19, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Add Core Divider clock support for Armada 370/XP

This patchset adds support for a set of clocks available in Armada 370/XP known as "Core Divider" clocks.

These are a set of gatable clocks, derived from a fixed PLL at a configurable ratio. Although this patchset adds support for the more general case, we only support one of the clocks, namely the NAND clock.

With this infrastructure in place, the addition of the rest of the clocks would be fairly easy.

A pictorical representation of the clock tree would be:

    PLL
    |
    |
    ---------------------
    |			|
    |			|
    NAND clock		...

This patchset is based on v3.12-rc2. Any opinions are highly appreciated.

Thanks!

Changes from v1:

* The most significative change is the simplification of the NAND clock tree. Instead of exposing two clocks: NAND ECC and NAND, we choose a simpler approach and view both clocks as one.

The only impact these simplification has is that the NAND controller driver will have to divide the rate by two when using it to calculate the timings.

* A spinlock protecting the enable, disable and set_rate operations is added as noted by Andrew Lunn.

* The round_rate algorithm was also simplified, as the previous one was rather silly; also noted by Andrew.

* The size of the 'reg' property was fixed; also noted by Andrew.

* The exceedingly long macros names have been simplified and some other minor coding style issues have been solved.

Ezequiel Garcia (4):
clk: mvebu: Add Core Divider clock
ARM: mvebu: Add Core Divider clock device-tree binding
ARM: mvebu: Add a 2 GHz fixed-clock Armada 370/XP
ARM: mvebu: Add the core-divider clock to Armada 370/XP

 .../bindings/clock/mvebu-corediv-clock.txt         |  19 ++
 arch/arm/boot/dts/armada-370-xp.dtsi               |  17 ++
 drivers/clk/mvebu/Kconfig                          |   5 +
 drivers/clk/mvebu/Makefile                         |   1 +
 drivers/clk/mvebu/clk-corediv.c                    | 223 +++++++++++++++++++++
 5 files changed, 265 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mvebu-corediv-clock.txt
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
drivers/clk/mvebu/Kconfig +5 -0
index 0b0f3e7..c339b82 100644
@@ -4,15 +4,20 @@ config MVEBU_CLK_COMMON
 config MVEBU_CLK_CPU
 	bool
 
+config MVEBU_CLK_COREDIV
+	bool
+
 config ARMADA_370_CLK
 	bool
 	select MVEBU_CLK_COMMON
 	select MVEBU_CLK_CPU
+	select MVEBU_CLK_COREDIV
 
 config ARMADA_XP_CLK
 	bool
 	select MVEBU_CLK_COMMON
 	select MVEBU_CLK_CPU
+	select MVEBU_CLK_COREDIV
 
 config DOVE_CLK
 	bool
drivers/clk/mvebu/Makefile +1 -0
index 1c7e70c..21bbfb4 100644
@@ -1,5 +1,6 @@
 obj-$(CONFIG_MVEBU_CLK_COMMON)	+= common.o
 obj-$(CONFIG_MVEBU_CLK_CPU) 	+= clk-cpu.o
+obj-$(CONFIG_MVEBU_CLK_COREDIV)	+= clk-corediv.o
 
 obj-$(CONFIG_ARMADA_370_CLK)	+= armada-370.o
 obj-$(CONFIG_ARMADA_XP_CLK)	+= armada-xp.o
drivers/clk/mvebu/clk-corediv.c new file +223 -0

223 lines not on this page · raw message

Signature · 1 line
1.8.1.5
#2 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 5 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

Quoted 8 lines
---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c

Please let me know once this gets pulled into the clock tree, and I'll pull in the remaining patches.

thx,

Jason.

#3 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 15 lines · Jason Cooper
Quoted 5 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

Quoted 8 lines
---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 2 lines

Mike: any comments on this?

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#4 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 16 lines · Ezequiel Garcia
Quoted 15 lines · Jason Cooper
Quoted 13 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Thanks!

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#5 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 20 lines · Ezequiel Garcia
Quoted 19 lines · Ezequiel Garcia
Quoted 17 lines · Jason Cooper
Quoted 5 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

Quoted 8 lines
---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 8 lines
Quoted 1 line

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#6 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 25 lines · Ezequiel Garcia
Quoted 24 lines · Ezequiel Garcia
Quoted 16 lines · Ezequiel Garcia
Quoted 15 lines · Jason Cooper
Quoted 13 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

Quoted 7 lines
Quoted 4 lines

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

The patches have been reviewed by Gregory and have your Ack, but unfortunately I don't know if Mike took a look on them.

On the other side, this adds a new clock to be used with NAND, so it's completely isolated and innocuous.

I hate to re-route patches this way -so feel free to refuse- but other I don't see any way this can be in v3.13.

Thanks!

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#7 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 31 lines · Ezequiel Garcia
Quoted 30 lines · Ezequiel Garcia
Quoted 28 lines · Ezequiel Garcia
Quoted 16 lines · Ezequiel Garcia
Quoted 15 lines · Jason Cooper
Quoted 13 lines · Ezequiel Garcia

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Quoted 5 lines
Quoted 2 lines

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

I considered it, and it didn't sit well with me. I don't mind taking a bugfix, everyone wants to see those moved along. However, this is an entirely new driver. Yes, it's scope of use is limited, but I'd prefer to let the maintainer review the driver before agreeing to maintain it. Otherwise, I'd be forcing him to maintain something he hasn't even looked at. :(

I know it sucks, but we're going to wait for Mike.

thx,

Jason.

#8 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoting Jason Cooper (2013-10-17 12:25:45)

Quoted 38 lines · Ezequiel Garcia
Quoted 31 lines · Ezequiel Garcia
Quoted 30 lines · Ezequiel Garcia
Quoted 28 lines · Ezequiel Garcia
Quoted 16 lines · Jason Cooper
Quoted 15 lines · Ezequiel Garcia
Quoted 13 lines

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Quoted 5 lines
Quoted 2 lines

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

Quoted 8 lines

I considered it, and it didn't sit well with me. I don't mind taking a bugfix, everyone wants to see those moved along. However, this is an entirely new driver. Yes, it's scope of use is limited, but I'd prefer to let the maintainer review the driver before agreeing to maintain it. Otherwise, I'd be forcing him to maintain something he hasn't even looked at. :(

I know it sucks, but we're going to wait for Mike.

Sorry for the delay. This driver looks fine and I've taken it into clk-next.

Thanks!
Mike

Quoted 4 lines

thx,

Jason.

#9 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 46 lines · Mike Turquette

Quoting Jason Cooper (2013-10-17 12:25:45)

Quoted 45 lines · Ezequiel Garcia
Quoted 31 lines · Ezequiel Garcia
Quoted 30 lines · Ezequiel Garcia
Quoted 28 lines · Ezequiel Garcia
Quoted 16 lines · Jason Cooper
Quoted 15 lines · Ezequiel Garcia
Quoted 13 lines

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Quoted 5 lines
Quoted 2 lines

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

I considered it, and it didn't sit well with me. I don't mind taking a bugfix, everyone wants to see those moved along. However, this is an entirely new driver. Yes, it's scope of use is limited, but I'd prefer to let the maintainer review the driver before agreeing to maintain it. Otherwise, I'd be forcing him to maintain something he hasn't even looked at. :(

Quoted 5 lines
Quoted 1 line

I know it sucks, but we're going to wait for Mike.

Sorry for the delay. This driver looks fine and I've taken it into clk-next.

No problem, thanks Mike!

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#10 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

In reply to Mike Turquette

Hi Mike,

Quoted 46 lines · Mike Turquette

Quoting Jason Cooper (2013-10-17 12:25:45)

Quoted 45 lines · Ezequiel Garcia
Quoted 31 lines · Ezequiel Garcia
Quoted 30 lines · Ezequiel Garcia
Quoted 28 lines · Ezequiel Garcia
Quoted 16 lines · Jason Cooper
Quoted 15 lines · Ezequiel Garcia
Quoted 13 lines

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Quoted 5 lines
Quoted 2 lines

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

I considered it, and it didn't sit well with me. I don't mind taking a bugfix, everyone wants to see those moved along. However, this is an entirely new driver. Yes, it's scope of use is limited, but I'd prefer to let the maintainer review the driver before agreeing to maintain it. Otherwise, I'd be forcing him to maintain something he hasn't even looked at. :(

Quoted 5 lines
Quoted 1 line

I know it sucks, but we're going to wait for Mike.

Sorry for the delay. This driver looks fine and I've taken it into clk-next.

This commit doesn't seem to be in clk-next (or in any other place), nearly two months after I submitted it, and after a month I was told it was accepted.

What's going on?

I really hope I'm missing something or I'm looking at the wrong tree.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#11 lore raw

PATCH v2 1/4 clk: mvebu: Add Core Divider clock

Quoted 55 lines · Ezequiel Garcia

Hi Mike,

Quoted 46 lines · Mike Turquette

Quoting Jason Cooper (2013-10-17 12:25:45)

Quoted 45 lines · Ezequiel Garcia
Quoted 31 lines · Ezequiel Garcia
Quoted 30 lines · Ezequiel Garcia
Quoted 28 lines · Ezequiel Garcia
Quoted 16 lines · Jason Cooper
Quoted 15 lines · Ezequiel Garcia
Quoted 13 lines

This commit introduces a new group of clocks present in Armada 370/XP SoCs (called "Core Divider" clocks) and add a provider for them. The only clock supported for now is the NAND clock (ndclk), but the infrastructure to add the rest is already set.

---
 drivers/clk/mvebu/Kconfig       |   5 +
 drivers/clk/mvebu/Makefile      |   1 +
 drivers/clk/mvebu/clk-corediv.c | 223 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+)
 create mode 100644 drivers/clk/mvebu/clk-corediv.c
Quoted 4 lines
Quoted 2 lines

Mike: any comments on this?

ping?

I'd like to move along with the NAND driver for this controller and -although these are not a hard requirement- it would be nice to have them merged.

Quoted 5 lines
Quoted 2 lines

Mike? Any chance you pick these soon? It's been almost three-weeks since these patchset has been sent and I'm starting to forget the details of it ;)

Jason: It seems Mike went on 'stealth mode' so I'm wondering if you would consider taking this patchset through you (given it's for our SoCs).

I considered it, and it didn't sit well with me. I don't mind taking a bugfix, everyone wants to see those moved along. However, this is an entirely new driver. Yes, it's scope of use is limited, but I'd prefer to let the maintainer review the driver before agreeing to maintain it. Otherwise, I'd be forcing him to maintain something he hasn't even looked at. :(

Quoted 5 lines
Quoted 1 line

I know it sucks, but we're going to wait for Mike.

Sorry for the delay. This driver looks fine and I've taken it into clk-next.

Quoted 7 lines

This commit doesn't seem to be in clk-next (or in any other place), nearly two months after I submitted it, and after a month I was told it was accepted.

What's going on?

I really hope I'm missing something or I'm looking at the wrong tree.

Hi Mike,

This commit seems to be in your clk-next-3.13-fail branch:

http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=shortlog;h=refs/heads/clk-next-3.13-fail

What's the purpose of this branch? Why is the commit there and not in clk-next?

If there's anything to review on this driver, just let me know so we can have this merged and move forward with the NAND support.

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#12 lore raw

PATCH v2 2/4 ARM: mvebu: Add Core Divider clock device-tree binding

In reply to Ezequiel Garcia

The Armada 370/XP SoCs have a Core Divider clock providing several clocks. For now, only the NAND clock is supported.

---
 .../devicetree/bindings/clock/mvebu-corediv-clock.txt | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mvebu-corediv-clock.txt
Documentation/devicetree/bindings/clock/mvebu-corediv-clock.txt new file +19 -0
new file mode 100644
index 0000000..c62391f
@@ -0,0 +1,19 @@
+* Core Divider Clock bindings for Marvell MVEBU SoCs
+
+The following is a list of provided IDs and clock names on Armada 370/XP:
+ 0 = nand (NAND clock)
+
+Required properties:
+- compatible : must be "marvell,armada-370-corediv-clock"
+- reg : must be the register address of Core Divider control register
+- #clock-cells : from common clock binding; shall be set to 1
+- clocks : must be set to the parent's phandle
+
+Example:
+
+corediv_clk: corediv-clocks at 18740 {
+	compatible = "marvell,armada-370-corediv-clock";
+	reg = <0x18740 0xc>;
+	#clock-cells = <1>;
+	clocks = <&pll>;
+};
Signature · 1 line
1.8.1.5
#13 lore raw

PATCH v2 3/4 ARM: mvebu: Add a 2 GHz fixed-clock Armada 370/XP

In reply to Ezequiel Garcia

Armada 370/XP SoCs have a 2 GHz fixed PLL that is used to feed other clocks. This commit adds a DT representation of this clock through a fixed-clock compatible node.

---
 arch/arm/boot/dts/armada-370-xp.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/armada-370-xp.dtsi +9 -0
index 1de2dae..924c721 100644
@@ -252,4 +252,13 @@
 
 		};
 	};
+
+	clocks {
+		/* 2 GHz fixed main PLL */
+		mainpll: mainpll {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <2000000000>;
+		};
+	};
  };
Signature · 1 line
1.8.1.5
#14 lore raw

PATCH v2 4/4 ARM: mvebu: Add the core-divider clock to Armada 370/XP

In reply to Ezequiel Garcia

The Armada 370/XP SoC has a clock provider called "Core Divider", that is derived from a fixed 2 GHz PLL clock.

---
 arch/arm/boot/dts/armada-370-xp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/armada-370-xp.dtsi +8 -0
index 924c721..01e69fc 100644
@@ -137,6 +137,14 @@
 				status = "disabled";
 			};
 
+			coredivclk: corediv-clock at 18740 {
+				compatible = "marvell,armada-370-corediv-clock";
+				reg = <0x18740 0xc>;
+				#clock-cells = <1>;
+				clocks = <&mainpll>;
+				clock-output-names = "nand";
+			};
+
 			timer at 20300 {
 				reg = <0x20300 0x30>, <0x21040 0x30>;
 				interrupts = <37>, <38>, <39>, <40>, <5>, <6>;
Signature · 1 line
1.8.1.5