Skip to contentSkip to conversation

net: wireless: replace printk with netdev_warn in adm8211.c

PATCH Superseded Georgiana Rodica Chelu 2 participants 2 messages Oct 24, 2013 Networking drivers (wireless)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Georgiana Rodica Chelu

author
#0 lore raw

PATCH v2 1/3 net: wireless: replace printk with netdev_warn in adm8211.c

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...

Signed-off-by Georgiana Rodica Chelu <[email protected]>
---
 drivers/net/wireless/adm8211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/adm8211.c +3 -2
index f9a24e5..0d0dcba 100644
@@ -151,8 +151,9 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else
 			priv->rf_type = ADM8211_TYPE_AIROHA;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
-		       pci_name(priv->pdev), (cr49 >> 3) & 0x7);
+		netdev_warn(priv->pdev, "(adm8211): Unknown RFtype %d\n",
+			    pci_name(priv->pdev), (cr49 >> 3) & 0x7);
+
 	}
 
 	priv->bbp_type = cr49 & 0x7;
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 2 lines · Georgiana Rodica Chelu

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...

Hi Georgiana.

Please compile and test your patches before submitting them.

Quoted 4 lines
drivers/net/wireless/adm8211.c +0 -0
@@ -151,8 +151,9 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
 		else

drivers/net/wireless/adm8211.c static int adm8211_read_eeprom(struct ieee80211_hw *dev) · line 159

Quoted 10 lines
drivers/net/wireless/adm8211.c +3 -2
 			priv->rf_type = ADM8211_TYPE_AIROHA;
 
-		printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
-		       pci_name(priv->pdev), (cr49 >> 3) & 0x7);
+		netdev_warn(priv->pdev, "(adm8211): Unknown RFtype %d\n",
+			    pci_name(priv->pdev), (cr49 >> 3) & 0x7);
+
 	}
 
 	priv->bbp_type = cr49 & 0x7;

netdev_warn 1st arg is a struct net_device *
priv->pdev is a struct pci_dev *