Skip to contentSkip to conversation

PCI: imx6: increase link startup

PATCH New Tim Harvey 4 participants 4 messages Oct 23, 2013 – Oct 30, 2013

Subsystems (2)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 PCI: imx6: increase link startup

An increase link startup delay is required when certain PCI switches are attached to the root complex. This was tested with a Pericom switch and a PLX switch.

From: Marek Vasut <[email protected]>

---
 drivers/pci/host/pci-imx6.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-imx6.c +1 -1
index 90fce05..34c571a 100644
@@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
 	while (!dw_pcie_link_up(pp)) {
 		usleep_range(100, 1000);
 		count++;
-		if (count >= 10) {
+		if (count >= 200) {
 			dev_err(pp->dev, "phy link never came up\n");
 			dev_dbg(pp->dev,
 				"DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 PCI: imx6: increase link startup

Quoted 7 lines · Tim Harvey

An increase link startup delay is required when certain PCI switches are attached to the root complex. This was tested with a Pericom switch and a PLX switch.

From: Marek Vasut <[email protected]>

Quoted 20 lines
---
 drivers/pci/host/pci-imx6.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-imx6.c +1 -1
index 90fce05..34c571a 100644
@@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
 	while (!dw_pcie_link_up(pp)) {
 		usleep_range(100, 1000);
 		count++;
-		if (count >= 10) {
+		if (count >= 200) {
 			dev_err(pp->dev, "phy link never came up\n");
 			dev_dbg(pp->dev,
 				"DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
Signature · 1 line
1.7.9.5
maintainer
#2 lore raw

PATCH 1/1 PCI: imx6: increase link startup

In reply to Tim Harvey
Quoted 7 lines · Tim Harvey

An increase link startup delay is required when certain PCI switches are attached to the root complex. This was tested with a Pericom switch and a PLX switch.

From: Marek Vasut <[email protected]>

I applied this with Shawn's ack to my pci/host-imx6 branch for v3.13, thanks!

I assume the intent was that this patch was written by Marek, per the "From:" line you added above, so I fixed that in the patch so Marek appears as the author. Let me know if this is incorrect.

Quoted 20 lines
---
 drivers/pci/host/pci-imx6.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-imx6.c +1 -1
index 90fce05..34c571a 100644
@@ -318,7 +318,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
 	while (!dw_pcie_link_up(pp)) {
 		usleep_range(100, 1000);
 		count++;
-		if (count >= 10) {
+		if (count >= 200) {
 			dev_err(pp->dev, "phy link never came up\n");
 			dev_dbg(pp->dev,
 				"DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 1/1 PCI: imx6: increase link startup

Dear Bjorn Helgaas,

Quoted 9 lines · Tim Harvey
Quoted 7 lines

An increase link startup delay is required when certain PCI switches are attached to the root complex. This was tested with a Pericom switch and a PLX switch.

From: Marek Vasut <[email protected]>

Quoted 6 lines

I applied this with Shawn's ack to my pci/host-imx6 branch for v3.13, thanks!

I assume the intent was that this patch was written by Marek, per the "From:" line you added above, so I fixed that in the patch so Marek appears as the author. Let me know if this is incorrect.

I'm really glad Tim split this patch while I am being totally unhelpful here on the PCIe front in last few days. Thank you!

Best regards,
Marek Vasut