Skip to contentSkip to conversation

Add power control for lm90

PATCH In review Wei Ni 3 participants 16 messages Oct 7, 2013 – Nov 15, 2013 11 messages not in the archive

Subsystems (4)
lore
Share & tools
lore

Wei Ni

author
#0 lore raw

v5 cover Add power control for lm90

The device lm90 can be controlled by the vcc rail. Add function to power on/off the vcc.
I will update all .dts files referencing this driver to match the new requirement in my next series.

This series is v5, previous version patches are:
[v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
[v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
[v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
[v1]: http://www.mail-archive.com/[email protected]/msg12034.html

Changes from v4:
1. set vcc-supply as required property.

Changes from v3:
1. change to use devm_regulator_get, as per discussion in previous patches.
2. just return errors when get error from regulator_get(), Mark's new dummy regulator can cope with errors.
3. add vendor prefix for GMT
3. list manufacturer in the binding doc.

Changes from v2:
1. use devm_regulator_get_optional(), as suggested by Mark.
2. remove the lm90_power_control(), enable the regulator in the probe() directly, so the codes are more clear, as suggested by Alexander and Guenter.
3. change the binding documentation, as per Stephen suggestion.
4. couple of changes, as per previous review.

Changes from v1:
1. if get regulator failed, we should continue to run probe function, not return fail.
2. call regulator_put() in error handler and remove function.
3. add LM90 DT binding document.

Wei Ni (3):
hwmon: (lm90) Add power control
of: add vendor prefix for GMT
Documentation: dt: hwmon: add OF document for LM90

 Documentation/devicetree/bindings/hwmon/lm90.txt   |   44 ++++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/hwmon/lm90.c                               |   19 +++++++++
 3 files changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1381137940-22608-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

author
#2 lore raw

PATCH v5 1/3 hwmon: (lm90) Add power control

The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the "vcc" regulator before accessing the device.

---
 drivers/hwmon/lm90.c |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
drivers/hwmon/lm90.c +19 -0
index cdff742..3f51680 100644
@@ -89,6 +89,7 @@
 #include <linux/err.h>
 #include <linux/mutex.h>
 #include <linux/sysfs.h>
+#include <linux/regulator/consumer.h>
 
 /*
  * Addresses to scan
@@ -302,6 +303,7 @@ static const struct lm90_params lm90_params[] = {
 struct lm90_data {
 	struct device *hwmon_dev;
 	struct mutex update_lock;
+	struct regulator *lm90_reg;
 	char valid; /* zero until following fields are valid */
 	unsigned long last_updated; /* in jiffies */
 	int kind;
@@ -1397,8 +1399,20 @@ static int lm90_probe(struct i2c_client *client,
 	struct device *dev = &client->dev;
 	struct i2c_adapter *adapter = to_i2c_adapter(dev->parent);
 	struct lm90_data *data;
+	struct regulator *reg;
 	int err;
 
+	reg = devm_regulator_get(dev, "vcc");
+	if (IS_ERR(reg))
+		return PTR_ERR(reg);
+
+	err = regulator_enable(reg);
+	if (err < 0) {
+		dev_err(&client->dev,
+			"Failed to enable regulator: %d\n", err);
+		return err;
+	}
+
 	data = devm_kzalloc(&client->dev, sizeof(struct lm90_data), GFP_KERNEL);
 	if (!data)
 		return -ENOMEM;
@@ -1406,6 +1420,8 @@ static int lm90_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, data);
 	mutex_init(&data->update_lock);
 
+	data->lm90_reg = reg;
+
 	/* Set the device type */
 	data->kind = id->driver_data;
 	if (data->kind == adm1032) {
@@ -1473,6 +1489,8 @@ exit_remove_files:
 	lm90_remove_files(client, data);
 exit_restore:
 	lm90_restore_conf(client, data);
+	regulator_disable(data->lm90_reg);
+
 	return err;
 }
 
@@ -1483,6 +1501,7 @@ static int lm90_remove(struct i2c_client *client)
 	hwmon_device_unregister(data->hwmon_dev);
 	lm90_remove_files(client, data);
 	lm90_restore_conf(client, data);
+	regulator_disable(data->lm90_reg);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1381137940-22608-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#4 lore raw

Re: [PATCH v5 1/3] hwmon: (lm90) Add power control

Hi Wei,

Quoted 8 lines · Wei Ni

The device lm90 can be controlled by the vcc rail. Adding the regulator support to power on/off the vcc rail. Enable the "vcc" regulator before accessing the device.

---
 drivers/hwmon/lm90.c |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Overall it looks good. I've also tested all the lm90 patches with my ADM1032 evaluation board and did not notice any regression, so things are looking good.

Two style comments:

Quoted 13 lines
drivers/hwmon/lm90.c +1 -0
index cdff742..3f51680 100644
@@ -89,6 +89,7 @@
 #include <linux/err.h>
 #include <linux/mutex.h>
 #include <linux/sysfs.h>
+#include <linux/regulator/consumer.h>
 
 /*
  * Addresses to scan

drivers/hwmon/lm90.c static const struct lm90_params lm90_params[] = { · line 306

Quoted 4 lines
drivers/hwmon/lm90.c +1 -0
@@ -302,6 +303,7 @@ static const struct lm90_params lm90_params[] = {
 struct lm90_data {
 	struct device *hwmon_dev;
 	struct mutex update_lock;
+	struct regulator *lm90_reg;

The lm90_ prefix is totally redundant here.

drivers/hwmon/lm90.c static int lm90_probe(struct i2c_client *client, · line 1402

Quoted 8 lines
drivers/hwmon/lm90.c +1 -0
 	char valid; /* zero until following fields are valid */
 	unsigned long last_updated; /* in jiffies */
 	int kind;
@@ -1397,8 +1399,20 @@ static int lm90_probe(struct i2c_client *client,
 	struct device *dev = &client->dev;
 	struct i2c_adapter *adapter = to_i2c_adapter(dev->parent);
 	struct lm90_data *data;
+	struct regulator *reg;

I don't like the use of "reg" as an abbreviation of "regulator", because "reg" is very commonly used as an abbreviation of "register" in device drivers, including hwmon drivers, and in particular in the lm90 driver. So this can lead to confusion. I prefer that "regulator" is spelled out fully, it's not that long and there are a limited number of occurrences.

Quoted 35 lines
drivers/hwmon/lm90.c +15 -0
 	int err;
 
+	reg = devm_regulator_get(dev, "vcc");
+	if (IS_ERR(reg))
+		return PTR_ERR(reg);
+
+	err = regulator_enable(reg);
+	if (err < 0) {
+		dev_err(&client->dev,
+			"Failed to enable regulator: %d\n", err);
+		return err;
+	}
+
 	data = devm_kzalloc(&client->dev, sizeof(struct lm90_data), GFP_KERNEL);
 	if (!data)
 		return -ENOMEM;
@@ -1406,6 +1420,8 @@ static int lm90_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, data);
 	mutex_init(&data->update_lock);
 
+	data->lm90_reg = reg;
+
 	/* Set the device type */
 	data->kind = id->driver_data;
 	if (data->kind == adm1032) {
@@ -1473,6 +1489,8 @@ exit_remove_files:
 	lm90_remove_files(client, data);
 exit_restore:
 	lm90_restore_conf(client, data);
+	regulator_disable(data->lm90_reg);
+
 	return err;
 }
 

drivers/hwmon/lm90.c static int lm90_remove(struct i2c_client *client) · line 1507

Quoted 7 lines
drivers/hwmon/lm90.c +1 -0
@@ -1483,6 +1501,7 @@ static int lm90_remove(struct i2c_client *client)
 	hwmon_device_unregister(data->hwmon_dev);
 	lm90_remove_files(client, data);
 	lm90_restore_conf(client, data);
+	regulator_disable(data->lm90_reg);
 
 	return 0;
 }

I'll clean this up myself before submission, no need to resend.

Thanks,

Signature · 1 line
Jean Delvare
author
#5 lore raw

PATCH v5 2/3 of: add vendor prefix for GMT

In reply to a message not in the archive

Adding Global Mixed-mode Technology Inc. to the list of devicetree vendor prefixes.

---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 2956800..634c35f 100644
@@ -28,6 +28,7 @@ est	ESTeem Wireless Modems
 fsl	Freescale Semiconductor
 GEFanuc	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
 gef	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
+gmt	Global Mixed-mode Technology Inc.
 hisilicon	Hisilicon Limited.
 hp	Hewlett Packard
 ibm	International Business Machines (IBM)
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1381137940-22608-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#7 lore raw

Re: [PATCH v5 2/3] of: add vendor prefix for GMT

Hi Wei,

Quoted 13 lines · Wei Ni

Adding Global Mixed-mode Technology Inc. to the list of devicetree vendor prefixes.

---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
index 2956800..634c35f 100644

Documentation/devicetree/bindings/vendor-prefixes.txt est ESTeem Wireless Modems · line 34

Quoted 7 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -28,6 +28,7 @@ est	ESTeem Wireless Modems
 fsl	Freescale Semiconductor
 GEFanuc	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
 gef	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
+gmt	Global Mixed-mode Technology Inc.
 hisilicon	Hisilicon Limited.
 hp	Hewlett Packard
 ibm	International Business Machines (IBM)

This patch looks good (except maybe for the missing comma before "Inc.") but I'm not the one who can apply it. If should be sent to the OF/DT maintainers as listed by ./scripts/get_maintainer.pl.

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#9 lore raw

Re: [PATCH v5 2/3] of: add vendor prefix for GMT

Quoted 11 lines · Jean Delvare

Hi Wei,

Quoted 8 lines · Wei Ni

Adding Global Mixed-mode Technology Inc. to the list of devicetree vendor prefixes.

---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines

Documentation/devicetree/bindings/vendor-prefixes.txt est ESTeem Wireless Modems · line 34

Quoted 12 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 2956800..634c35f 100644
@@ -28,6 +28,7 @@ est	ESTeem Wireless Modems
 fsl	Freescale Semiconductor
 GEFanuc	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
 gef	GE Fanuc Intelligent Platforms Embedded Systems, Inc.
+gmt	Global Mixed-mode Technology Inc.
 hisilicon	Hisilicon Limited.
 hp	Hewlett Packard
 ibm	International Business Machines (IBM)

This patch looks good (except maybe for the missing comma before "Inc.") but I'm not the one who can apply it. If should be sent to the OF/DT maintainers as listed by ./scripts/get_maintainer.pl.

Ok, I will update this patch, and send to OF/DT maintainer.

Thanks.
Wei.

Quoted 1 line
author
#10 lore raw

PATCH v5 3/3 Documentation: dt: hwmon: add OF document for LM90

In reply to a message not in the archive

Add OF document for LM90 in Documentation/devicetree/.

---
 Documentation/devicetree/bindings/hwmon/lm90.txt |   44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
Documentation/devicetree/bindings/hwmon/lm90.txt new file +44 -0
new file mode 100644
index 0000000..e863248
@@ -0,0 +1,44 @@
+* LM90 series thermometer.
+
+Required node properties:
+- compatible: manufacturer and chip name, one of
+		"adi,adm1032"
+		"adi,adt7461"
+		"adi,adt7461a"
+		"gmt,g781"
+		"national,lm90"
+		"national,lm86"
+		"national,lm89"
+		"national,lm99"
+		"dallas,max6646"
+		"dallas,max6647"
+		"dallas,max6649"
+		"dallas,max6657"
+		"dallas,max6658"
+		"dallas,max6659"
+		"dallas,max6680"
+		"dallas,max6681"
+		"dallas,max6695"
+		"dallas,max6696"
+		"onnn,nct1008"
+		"winbond,w83l771"
+		"nxp,sa56004"
+
+- reg: I2C bus address of the device
+
+- vcc-supply: vcc regulator for the supply voltage.
+
+Optional properties:
+- interrupts: Contains a single interrupt specifier which describes the
+              LM90 "-ALERT" pin output.
+              See interrupt-controller/interrupts.txt for the format.
+
+Example LM90 node:
+
+temp-sensor {
+	compatible = "onnn,nct1008";
+	reg = <0x4c>;
+	vcc-supply = <&palmas_ldo6_reg>;
+	interrupt-parent = <&gpio>;
+	interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+}
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1381137940-22608-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#12 lore raw

Re: [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90

Hi Wei,

Quoted 48 lines · Wei Ni

Add OF document for LM90 in Documentation/devicetree/.

---
 Documentation/devicetree/bindings/hwmon/lm90.txt |   44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
Documentation/devicetree/bindings/hwmon/lm90.txt new file +34 -0
new file mode 100644
index 0000000..e863248
@@ -0,0 +1,44 @@
+* LM90 series thermometer.
+
+Required node properties:
+- compatible: manufacturer and chip name, one of
+		"adi,adm1032"
+		"adi,adt7461"
+		"adi,adt7461a"
+		"gmt,g781"
+		"national,lm90"
+		"national,lm86"
+		"national,lm89"
+		"national,lm99"
+		"dallas,max6646"
+		"dallas,max6647"
+		"dallas,max6649"
+		"dallas,max6657"
+		"dallas,max6658"
+		"dallas,max6659"
+		"dallas,max6680"
+		"dallas,max6681"
+		"dallas,max6695"
+		"dallas,max6696"
+		"onnn,nct1008"
+		"winbond,w83l771"
+		"nxp,sa56004"
+
+- reg: I2C bus address of the device
+
+- vcc-supply: vcc regulator for the supply voltage.
+
+Optional properties:
+- interrupts: Contains a single interrupt specifier which describes the
+              LM90 "-ALERT" pin output.
+              See interrupt-controller/interrupts.txt for the format.

Documentation/devicetree/bindings/hwmon/lm90.txt line 44

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/lm90.txt new file +10 -0
+
+Example LM90 node:
+
+temp-sensor {
+	compatible = "onnn,nct1008";
+	reg = <0x4c>;
+	vcc-supply = <&palmas_ldo6_reg>;
+	interrupt-parent = <&gpio>;
+	interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+}

Looks good to me, just one question: is it OK that interrupt-parent is not described in the document? Is it supposed to be a standard property?

I'll add this file to the LM90 entry in MAINTAINERS, so that I can pick this patch in my tree.

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#14 lore raw

Re: [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90

Quoted 4 lines · Jean Delvare

Hi Wei,

Quoted 1 line · Wei Ni

Add OF document for LM90 in Documentation/devicetree/.

...

Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/hwmon/lm90.txt new file +5 -0
+
+Example LM90 node:
+
+temp-sensor {
+	compatible = "onnn,nct1008";
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/lm90.txt line 44

Quoted 5 lines
Documentation/devicetree/bindings/hwmon/lm90.txt new file +5 -0
+	reg = <0x4c>;
+	vcc-supply = <&palmas_ldo6_reg>;
+	interrupt-parent = <&gpio>;
+	interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+}

Looks good to me, just one question: is it OK that interrupt-parent is not described in the document? Is it supposed to be a standard property?

As Stephen said in this series v3:
"I believe it's common not to document this, since it's implicitly supported as part of any node that is an interrupt source." This is a standard property.

Quoted 3 lines

I'll add this file to the LM90 entry in MAINTAINERS, so that I can pick this patch in my tree.

Thanks again.
Wei.

Quoted 1 line

A message that is not in the archive (sent off-list or not yet received): [email protected]

#16 lore raw

Re: [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90

Quoted 20 lines · Wei Ni
Quoted 4 lines · Jean Delvare

Hi Wei,

Quoted 1 line · Wei Ni

Add OF document for LM90 in Documentation/devicetree/.

...

Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/hwmon/lm90.txt new file +5 -0
+
+Example LM90 node:
+
+temp-sensor {
+	compatible = "onnn,nct1008";
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/lm90.txt line 44

Quoted 5 lines
Documentation/devicetree/bindings/hwmon/lm90.txt new file +5 -0
+	reg = <0x4c>;
+	vcc-supply = <&palmas_ldo6_reg>;
+	interrupt-parent = <&gpio>;
+	interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+}

Looks good to me, just one question: is it OK that interrupt-parent is not described in the document? Is it supposed to be a standard property?

Quoted 4 lines

As Stephen said in this series v3:
"I believe it's common not to document this, since it's implicitly supported as part of any node that is an interrupt source." This is a standard property.

Perfect, thanks for the clarification.

Signature · 1 line
Jean Delvare
author
#18 lore raw
In reply to a message not in the archive

Hi, Jean

Do you have any comments on this series, or will you take them ?

Thanks.
Wei.

Quoted 45 lines · Wei Ni

The device lm90 can be controlled by the vcc rail. Add function to power on/off the vcc.
I will update all .dts files referencing this driver to match the new requirement in my next series.

This series is v5, previous version patches are:
[v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
[v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
[v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
[v1]: http://www.mail-archive.com/[email protected]/msg12034.html

Changes from v4:
1. set vcc-supply as required property.

Changes from v3:
1. change to use devm_regulator_get, as per discussion in previous patches.
2. just return errors when get error from regulator_get(), Mark's new dummy regulator can cope with errors.
3. add vendor prefix for GMT
3. list manufacturer in the binding doc.

Changes from v2:
1. use devm_regulator_get_optional(), as suggested by Mark.
2. remove the lm90_power_control(), enable the regulator in the probe() directly, so the codes are more clear, as suggested by Alexander and Guenter.
3. change the binding documentation, as per Stephen suggestion.
4. couple of changes, as per previous review.

Changes from v1:
1. if get regulator failed, we should continue to run probe function, not return fail.
2. call regulator_put() in error handler and remove function.
3. add LM90 DT binding document.

Wei Ni (3):
hwmon: (lm90) Add power control
of: add vendor prefix for GMT
Documentation: dt: hwmon: add OF document for LM90

 Documentation/devicetree/bindings/hwmon/lm90.txt   |   44 ++++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/hwmon/lm90.c                               |   19 +++++++++
 3 files changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#20 lore raw
Quoted 3 lines · Wei Ni

Hi, Jean

Do you have any comments on this series, or will you take them ?

Hi, Jean, will you apply this series befor the 3.13 merge window?

Since I forgot to tell Stephen not to apply the "[PATCH 0/2] Update dts file to support lm90 well" untile this series are accept, so if without this change, the lm90 may be broken on the Dalmore board.

Thanks.
Wei.

Quoted 51 lines

Thanks.
Wei.

Quoted 45 lines · Wei Ni

The device lm90 can be controlled by the vcc rail. Add function to power on/off the vcc.
I will update all .dts files referencing this driver to match the new requirement in my next series.

This series is v5, previous version patches are:
[v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
[v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
[v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
[v1]: http://www.mail-archive.com/[email protected]/msg12034.html

Changes from v4:
1. set vcc-supply as required property.

Changes from v3:
1. change to use devm_regulator_get, as per discussion in previous patches.
2. just return errors when get error from regulator_get(), Mark's new dummy regulator can cope with errors.
3. add vendor prefix for GMT
3. list manufacturer in the binding doc.

Changes from v2:
1. use devm_regulator_get_optional(), as suggested by Mark.
2. remove the lm90_power_control(), enable the regulator in the probe() directly, so the codes are more clear, as suggested by Alexander and Guenter.
3. change the binding documentation, as per Stephen suggestion.
4. couple of changes, as per previous review.

Changes from v1:
1. if get regulator failed, we should continue to run probe function, not return fail.
2. call regulator_put() in error handler and remove function.
3. add LM90 DT binding document.

Wei Ni (3):
hwmon: (lm90) Add power control
of: add vendor prefix for GMT
Documentation: dt: hwmon: add OF document for LM90

 Documentation/devicetree/bindings/hwmon/lm90.txt   |   44 ++++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/hwmon/lm90.c                               |   19 +++++++++
 3 files changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#22 lore raw

Hi, Jean
Since no more comments on this series, could you take this series before the 3.13 merge window ?
Because if without this series, the lm90 will be broken on the Tegra Dalmore board, and this problem will be get into the v3.13 release.

Looking forward to your reply :)

Thanks.
Wei.

Quoted 66 lines · Wei Ni
Quoted 3 lines · Wei Ni

Hi, Jean

Do you have any comments on this series, or will you take them ?

Hi, Jean, will you apply this series befor the 3.13 merge window?

Since I forgot to tell Stephen not to apply the "[PATCH 0/2] Update dts file to support lm90 well" untile this series are accept, so if without this change, the lm90 may be broken on the Dalmore board.

Thanks.
Wei.

Quoted 51 lines

Thanks.
Wei.

Quoted 45 lines · Wei Ni

The device lm90 can be controlled by the vcc rail. Add function to power on/off the vcc.
I will update all .dts files referencing this driver to match the new requirement in my next series.

This series is v5, previous version patches are:
[v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
[v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
[v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
[v1]: http://www.mail-archive.com/[email protected]/msg12034.html

Changes from v4:
1. set vcc-supply as required property.

Changes from v3:
1. change to use devm_regulator_get, as per discussion in previous patches.
2. just return errors when get error from regulator_get(), Mark's new dummy regulator can cope with errors.
3. add vendor prefix for GMT
3. list manufacturer in the binding doc.

Changes from v2:
1. use devm_regulator_get_optional(), as suggested by Mark.
2. remove the lm90_power_control(), enable the regulator in the probe() directly, so the codes are more clear, as suggested by Alexander and Guenter.
3. change the binding documentation, as per Stephen suggestion.
4. couple of changes, as per previous review.

Changes from v1:
1. if get regulator failed, we should continue to run probe function, not return fail.
2. call regulator_put() in error handler and remove function.
3. add LM90 DT binding document.

Wei Ni (3):
hwmon: (lm90) Add power control
of: add vendor prefix for GMT
Documentation: dt: hwmon: add OF document for LM90

 Documentation/devicetree/bindings/hwmon/lm90.txt   |   44 ++++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/hwmon/lm90.c                               |   19 +++++++++
 3 files changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt

A message that is not in the archive (sent off-list or not yet received): [email protected]

#24 lore raw

Hi Wei,

I'm sorry again that I always take so much time reviewing your patches. I always have higher priority tasks at work and at the end of the day reviewing the lm90 patches never makes it to the top of my to-do list :( I'll try to review a few lm90 patches today...

Jean

Quoted 29 lines · Wei Ni

Hi, Jean
Since no more comments on this series, could you take this series before the 3.13 merge window ?
Because if without this series, the lm90 will be broken on the Tegra Dalmore board, and this problem will be get into the v3.13 release.

Looking forward to your reply :)

Thanks.
Wei.

Quoted 17 lines · Wei Ni
Quoted 3 lines · Wei Ni

Hi, Jean

Do you have any comments on this series, or will you take them ?

Hi, Jean, will you apply this series befor the 3.13 merge window?

Since I forgot to tell Stephen not to apply the "[PATCH 0/2] Update dts file to support lm90 well" untile this series are accept, so if without this change, the lm90 may be broken on the Dalmore board.

Thanks.
Wei.

Quoted 3 lines

Thanks.
Wei.

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#26 lore raw
Quoted 6 lines · Jean Delvare

Hi Wei,

I'm sorry again that I always take so much time reviewing your patches. I always have higher priority tasks at work and at the end of the day reviewing the lm90 patches never makes it to the top of my to-do list :( I'll try to review a few lm90 patches today...

I really appreciated you reviewed my patch so carefully. Since this series will block the lm90 on tegra board, so we wish to add this before v3.13 merge window.
Looking forward your comments on this series :)

Thanks.
Wei.

Quoted 33 lines

Jean

Quoted 29 lines · Wei Ni

Hi, Jean
Since no more comments on this series, could you take this series before the 3.13 merge window ?
Because if without this series, the lm90 will be broken on the Tegra Dalmore board, and this problem will be get into the v3.13 release.

Looking forward to your reply :)

Thanks.
Wei.

Quoted 17 lines · Wei Ni
Quoted 3 lines · Wei Ni

Hi, Jean

Do you have any comments on this series, or will you take them ?

Hi, Jean, will you apply this series befor the 3.13 merge window?

Since I forgot to tell Stephen not to apply the "[PATCH 0/2] Update dts file to support lm90 well" untile this series are accept, so if without this change, the lm90 may be broken on the Dalmore board.

Thanks.
Wei.

Quoted 3 lines

Thanks.
Wei.