Skip to contentSkip to conversation

video: backlight: gpio-backlight: Add DT support.

PATCH Superseded Denis Carikli 2 participants 2 messages Jan 7, 2014

Subsystems (4)

v8 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

PATCH v8 1/1 video: backlight: gpio-backlight: Add DT support.

Cc Richard Purdie <[email protected]>
Cc Jingoo Han <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

---
 .../bindings/video/backlight/gpio-backlight.txt    |   19 ++++++
 drivers/video/backlight/gpio_backlight.c           |   64 +++++++++++++++++---
 2 files changed, 76 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +19 -0
new file mode 100644
index 0000000..d022add
@@ -0,0 +1,19 @@
+gpio-backlight bindings
+
+Required properties:
+  - compatible: "gpio-backlight"
+  - gpios: describes the gpio that is used for enabling/disabling the backlight
+    (see GPIO binding[0] for more details).
+  - default-brightness-level: the default brightness level. Valid values:
+    - 0: off
+    - 1: on
+
+[0]: Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+
+	backlight {
+		compatible = "gpio-backlight";
+		gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
+		default-brightness-level = <1>;
+	};
drivers/video/backlight/gpio_backlight.c +57 -7

116 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v8 1/1 video: backlight: gpio-backlight: Add DT support.

Quoted 57 lines · Denis Carikli
Cc Richard Purdie <[email protected]>
Cc Jingoo Han <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Rob Herring <[email protected]>
Cc Pawel Moll <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Ian Campbell <[email protected]>
Cc devicetree at vger.kernel.org
Cc Sascha Hauer <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc Lothar Wa?mann <[email protected]>
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Eric B?nard <[email protected]>

---
ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

---
 .../bindings/video/backlight/gpio-backlight.txt    |   19 ++++++
 drivers/video/backlight/gpio_backlight.c           |   64 +++++++++++++++++---
 2 files changed, 76 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +0 -0
new file mode 100644
index 0000000..d022add

Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt line 9

Quoted 9 lines
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +9 -0
@@ -0,0 +1,19 @@
+gpio-backlight bindings
+
+Required properties:
+  - compatible: "gpio-backlight"
+  - gpios: describes the gpio that is used for enabling/disabling the backlight
+    (see GPIO binding[0] for more details).
+  - default-brightness-level: the default brightness level. Valid values:
+    - 0: off
+    - 1: on

If this is a boolean, use a boolean/empty property (default-on would be a good candidate, or you could have default-off if most people are gonig to want the display on at boot).

[...]

Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt line 11

Quoted 2 lines
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +2 -0
+	ret = of_property_read_u32(np, "default-brightness-level",
+				   &gbl->def_value);

This could be:

gbl->def_value = of_property_read_bool(np, "default-on");

Then you don't have to worry about people doing crazy things like having default-brightness-level = <6> when you only support a boolean value.

Thanks,
Mark.