Skip to contentSkip to conversation

ARM: twister: add missing gpio clock init

PATCH In review Jeroen Hofstee 3 participants 3 messages Dec 21, 2013 – Jan 8, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: twister: add missing gpio clock init

Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards which do not explicitly enable the gpio clocks. This causes the twister spl to hang, since it uses the no longer enabled gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.

Cc Stefano Babic <[email protected]>
Cc Tapani Utriainen <[email protected]>
---
 include/configs/twister.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/twister.h +3 -0
index b6ca59c..f24dc13 100644
@@ -50,4 +50,7 @@
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
 
+/* gpio 55 is used as SPL_OS_BOOT_KEY */
+#define CONFIG_OMAP3_GPIO_2
+
 #endif /* __CONFIG_H */
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 ARM: twister: add missing gpio clock init

Quoted 18 lines · Jeroen Hofstee

Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards which do not explicitly enable the gpio clocks. This causes the twister spl to hang, since it uses the no longer enabled gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.

Cc Stefano Babic <[email protected]>
Cc Tapani Utriainen <[email protected]>
---
 include/configs/twister.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/twister.h +0 -0
index b6ca59c..f24dc13 100644

include/configs/twister.h line 56

Quoted 7 lines
include/configs/twister.h +3 -0
@@ -50,4 +50,7 @@
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
 
+/* gpio 55 is used as SPL_OS_BOOT_KEY */
+#define CONFIG_OMAP3_GPIO_2
+
 #endif /* __CONFIG_H */

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw
In reply to Jeroen Hofstee
Quoted 9 lines · Jeroen Hofstee

Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards which do not explicitly enable the gpio clocks. This causes the twister spl to hang, since it uses the no longer enabled gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140108/6b1997c4/attachment.pgp>