Skip to contentSkip to conversation

additional model for sata_sil Mod15Write list

PATCH New matson 2 participants 2 messages Jan 30, 2014 – Feb 3, 2014 libata

lore
Share & tools
lore

matson

author
#0 lore raw

Tejun Heo:

Quoted 2 lines

Matson, can you please post the results of dd tries with varying io sizes from your previous email?

Those were numbers off the top of my head.  Here are real results:

dd oflag=direct if=/dev/zero of=/dev/sdb bs=7680 Never caused a problem.  I tried count as high as 100000.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=1 Caused timeout one time in one hundred trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=2 Caused timeout one time in one hundred trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=4 Caused timeout four times in one hundred trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=8 Caused timeout four times in one hundred trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=16 Caused timeout nine times in one hundred trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=32 Caused timeout fourteen times in fifty trials.

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=64 Caused timeout thirteen times in twenty-five trials.
(Nine runs with one 30s timeout; two runs with 60 seconds of timeouts.)

dd oflag=direct if=/dev/zero of=/dev/sdb bs=8192 count=128
Caused timeout seventeen times in ten trials.
(Two runs with one 30s timeout; one run with 60 seconds of timeouts; three runs with 90 seconds of timeouts; one run with 120 seconds of timeouts.)

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=16k Caused timeout zero times in one hundred trials.

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=32k Caused timeout six times in fifty trials.

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=64k Caused timeout three times in fifty trials.

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=128k Caused timeout five times in fifty trials.

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=256k Caused timeout eight times in fifty trials.
(Six runs with one 30s timeout; one run with 60 seconds of timeouts.)

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=512k Caused timeout sixteen times in twenty-five trials.
(Three runs with one 30s timeout; two runs with 60 seconds of timeouts; three runs with 90 seconds of timeouts.)

dd oflag=direct of=/dev/sdb if=/dev/zero count=1 bs=1024k

Yielded somewhat different information in dmesg:
ata9.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen ata9.00: failed command: WRITE DMA EXT
ata9.00: cmd 35/00:00:00:00:00/00:04:00:00:00/e0 tag 0 dma 524288 out res 40/00:01:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata9.00: status: { DRDY }
ata9: hard resetting link
ata0: SATA link up 1.5 Gbps (SStatus 113 SControl 310) ata9.00: configured for UDMA/33
ata9.00: device reported invalid CHS sector 0
sd 8:0:0:0: [sdb]
Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
sd 8:0:0:0: [sdb]
Sense Key : Aborted Command [current] [descriptor] Descriptor sense data with sense discriptors (in hex):
        72 0b 00 00 00 00 00 0c 00 0a 80 00 00 00 00 00
        00 00 00 00
sd 8:0:0:0: [sdb]
Add. Sense: No additional sense information
sd 8:0:0:0: [sdb] CDB:
Write(10): 2a 00 00 00 00 00 00 04 00 00
end_request: I/O error, dev sdb, sector 0
ata9: EH complete

Quoted 3 lines
Quoted 1 line

My HDD is HP part 625239, firmware is MH000C.  I do know whether


I suppose you meant to write "do not know"?

You are correct, I mistyped.  I have only this one drive, and I do _not_ know whether other models or firmwares have this problem. Mine is dated 22NOV2011.

Quoted 1 line

Can you please post the output "hdparm -I" on your device?

here it is:

/dev/sdb:

ATA device, with non-removable media
Model Number:       TOSHIBA MK2561GSYN
Serial Number:      Y1MGP3F0T
Firmware Revision:  MH000C
Transport:          Serial, ATA8-AST, SATA 1.0a, SATA II Extensions,
SATA Rev 2.5, SATA Rev 2.6
Standards:

	Supported: 8 7 6 5 
	Likely used: 8

Configuration:
Logical max current
cylinders 16383 16383
heads 16 16
sectors/track 63 63
--
CHS current addressable sectors:   16514064
LBA    user addressable sectors:  268435455
LBA48  user addressable sectors:  488397168
Logical  Sector size:                   512 bytes Physical Sector size:                   512 bytes
device size with M = 1024*1024:      238475 MBytes
device size with M = 1000*1000:      250059 MBytes (250 GB) cache/buffer size  = 16384 KBytes
Form Factor: 2.5 inch
Nominal Media Rotation Rate: 7200
Capabilities:
LBA, IORDY(can be disabled)
Queue depth: 32
Standby timer values: spec'd by Standard, no device specific minimum
R/W multiple sector transfer: Max = 16 Current = 16
Advanced power management level: 128
DMA: sdma0 sdma1 sdma2 mdma0 mdma1 mdma2 udma0 udma1 udma2 udma3 udma4
*udma5
    Cycle time: min=120ns recommended=120ns
PIO: pio0 pio1 pio2 pio3 pio4
    Cycle time: no flow control=120ns  IORDY flow control=120ns
Commands/features:
Enabled Supported:
  * SMART feature set
    Security Mode feature set
  * Power Management feature set
  * Write cache
  * Look-ahead
  * WRITE_BUFFER command
  * READ_BUFFER command
  * NOP cmd
  * DOWNLOAD_MICROCODE
  * Advanced Power Management feature set
  * 48-bit Address feature set
  * Device Configuration Overlay feature set
  * Mandatory FLUSH_CACHE
  * FLUSH_CACHE_EXT
  * SMART error logging
  * SMART self-test
  * General Purpose Logging feature set
  * 64-bit World wide name
  * IDLE_IMMEDIATE with UNLOAD
  * WRITE_UNCORRECTABLE_EXT command
  * {READ,WRITE}_DMA_EXT_GPL commands
  * Segmented DOWNLOAD_MICROCODE
  * Gen1 signaling speed (1.5Gb/s)
  * Gen2 signaling speed (3.0Gb/s)
  * Native Command Queueing (NCQ)
  * Phy event counters
  * Idle-Unload when NCQ is active
    DMA Setup Auto-Activate optimization Device-initiated interface power management
  * Software settings preservation
  * SMART Command Transport (SCT) feature set
  * SCT Read/Write Long (AC1), obsolete
  * SCT Write Same (AC2)
  * SCT Error Recovery Control (AC3)
  * SCT Features Control (AC4)
  * SCT Data Tables (AC5)
Security:
Master password revision code = 65534
supported
not enabled
not locked
not frozen
not expired: security count
supported: enhanced erase
54min for SECURITY ERASE UNIT. 54min for ENHANCED SECURITY ERASE UNIT.
Logical Unit WWN Device Identifier: 50000393a290a53e

	NAA		: 5
	IEEE OUI	: 000039
	Unique ID	: 3a290a53e

Checksum: correct

#1 lore raw

PATCH 1/1 sata_sil: apply MOD15WRITE quirk to TOSHIBA MK2561GSYN

Quoted 1 line

From 9f9c47f00ce99329b1a82e2ac4f70f0fe3db549c Mon Sep 17 00:00:00 2001

From: Tejun Heo <[email protected]>
Date: Mon, 3 Feb 2014 10:42:07 -0500

It's a bit odd to see a newer device showing mod15write; however, the reported behavior is highly consistent and other factors which could contribute seem to have been verified well enough. Also, both sata_sil itself and the drive are fairly outdated at this point making the risk of this change fairly low. It is possible, probably likely, that other drive models in the same family have the same problem; however, for now, let's just add the specific model which was tested.

References: http://lkml.kernel.org/g/[email protected]
Cc: [email protected]
---
Applied to libata/for-3.14-fixes.

Thanks!

 drivers/ata/sata_sil.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ata/sata_sil.c +1 -0
index d67fc35..b7695e8 100644
@@ -157,6 +157,7 @@ static const struct sil_drivelist {
 	{ "ST380011ASL",	SIL_QUIRK_MOD15WRITE },
 	{ "ST3120022ASL",	SIL_QUIRK_MOD15WRITE },
 	{ "ST3160021ASL",	SIL_QUIRK_MOD15WRITE },
+	{ "TOSHIBA MK2561GSYN",	SIL_QUIRK_MOD15WRITE },
 	{ "Maxtor 4D060H3",	SIL_QUIRK_UDMA5MAX },
 	{ }
 };
Signature · 1 line
1.8.5.3