drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak in the error path of tda998x_encoder_init
Picked up by the nightly Coverity scan. CID 1174076
Signed-off-by Dave Jones <[email protected]>
drivers/gpu/drm/i2c/tda998x_drv.c +3 -1
@@ -1151,8 +1151,10 @@ tda998x_encoder_init(struct i2c_client *client, priv->current_page =0xff ; priv->cec =i2c_new_dummy (client->adapter,0x34 ); -if (!priv->cec) +if (!priv->cec) { +kfree (priv);return -ENODEV ; + } priv->dpms =DRM_MODE_DPMS_OFF ; encoder_slave->slave_priv = priv;
Quoted 6 lines · Dave Jones
Commit
6ae668cc19e8b18df28cd67b3448d9abd79284a4introduced a memory leak in the error path oftda998x_encoder_initPicked up by the nightly Coverity scan. CID 1174076
Signed-off-by Dave Jones <[email protected]>
Thanks Dave, patch applied, and will send to airlied soon.
Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit".