Skip to contentSkip to conversation

drm/i2c: tda998x: Fix memory leak in tda998x_encoder_init error path.

PATCH Dave Jones 2 participants 2 messages Feb 13, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw

Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak in the error path of tda998x_encoder_init

Picked up by the nightly Coverity scan. CID 1174076

drivers/gpu/drm/i2c/tda998x_drv.c +3 -1
index fa18cf374470..faa77f543a07 100644
@@ -1151,8 +1151,10 @@ tda998x_encoder_init(struct i2c_client *client,
 
 	priv->current_page = 0xff;
 	priv->cec = i2c_new_dummy(client->adapter, 0x34);
-	if (!priv->cec)
+	if (!priv->cec) {
+		kfree(priv);
 		return -ENODEV;
+	}
 	priv->dpms = DRM_MODE_DPMS_OFF;
 
 	encoder_slave->slave_priv = priv;
#2 lore raw
Quoted 6 lines · Dave Jones

Commit 6ae668cc19e8b18df28cd67b3448d9abd79284a4 introduced a memory leak in the error path of tda998x_encoder_init

Picked up by the nightly Coverity scan. CID 1174076

Thanks Dave, patch applied, and will send to airlied soon.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".