Skip to contentSkip to conversation

watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

PATCH Superseded Fabio Estevam 5 participants 10 messages Feb 18, 2014 – Feb 25, 2014 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Signature · 1 line
1.8.1.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Fabio Estevam

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

Acked-by on v1 1/1
#2 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

Signature · 7 lines
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
In reply to Fabio Estevam

Hi Ezequiel,

Can you have a look at the below patch?

Kind regards,
Wim.

Quoted 30 lines

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Signature · 1 line
1.8.1.2
#4 lore raw
Quoted 3 lines · Wim Van Sebroeck

Can you have a look at the below patch?

I've acked-it yesterday, I think.

Do you want me to re-send the mail?

Signature · 7 lines
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw

Hi Ezequiel,

Quoted 8 lines · Wim Van Sebroeck
Quoted 3 lines

Can you have a look at the below patch?

I've acked-it yesterday, I think.

Do you want me to re-send the mail?

Not needed :-). I have it.

Kind regards,
Wim.

#6 lore raw
In reply to Fabio Estevam

Hi All,

Quoted 30 lines

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Signature · 1 line
1.8.1.2

Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also thereà?

Kind regards,
Wim.

#7 lore raw

PATCH 1/1 watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

Jason,

Quoted 26 lines · Wim Van Sebroeck
Quoted 26 lines

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Quoted 7 lines
Quoted 4 lines
Signature · 1 line
1.8.1.2

Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??

Can you pull this too? It's been acked by Wim and me.

Thanks,

Signature · 3 lines
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
#8 lore raw

PATCH 1/1 watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

Quoted 37 lines · Ezequiel Garcia

Jason,

Quoted 26 lines · Wim Van Sebroeck
Quoted 26 lines

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Quoted 7 lines
Quoted 4 lines
Signature · 1 line
1.8.1.2

Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??

Quoted 1 line

Can you pull this too? It's been acked by Wim and me.

Yep, I'll add it onto the stack.

thx,

Jason.

#9 lore raw

PATCH 1/1 watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

In reply to Ezequiel Garcia

Fabio,

Quoted 37 lines · Ezequiel Garcia

Jason,

Quoted 26 lines · Wim Van Sebroeck
Quoted 26 lines

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Quoted 7 lines
Quoted 4 lines
Signature · 1 line
1.8.1.2

Acked-by me also, but can this also go via the mvebu tree (since the patch that introduces this is also there??

Quoted 1 line

Can you pull this too? It's been acked by Wim and me.

I don't have a local archive of the watchdog ML, could you resend the patch to me?

thx,

Jason.