staging: ced401: fix double unlock bug
PATCH v2 1/1 staging: ced401: fix double unlock bug
After spin_lock() is called, all of if-else conditions in this brace should reach the end of else and spin_unlock() must be called. So It doesn't need to call spin_unlock() without a return statement for handling an error.
Also sparse says:drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
--- drivers/staging/ced1401/usb1401.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/ced1401/usb1401.c +0 -1
@@ -1053,7 +1053,6 @@ static int Handle1401Esc(DEVICE_EXTENSION *pdx, char *pCh,/* This can never happen, really */ dev_err (&pdx->interface->dev,"ERROR: DMA setup while transfer still waiting" ); -spin_unlock (&pdx->stagedLock); }else {if ((wTransType ==TM_EXTTOHOST ) || (wTransType ==TM_EXTTO1401 )) {
Signature · 3 lines
1.7.9.5 ---
Quoted 10 lines · Daeseok Youn
After
spin_lock()is called, all of if-else conditions in this brace should reach the end of else andspin_unlock()must be called. So It doesn't need to callspin_unlock()without a return statement for handling an error.Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Thank you.
regards,
dan carpenter
Greg KH
maintainerQuoted 11 lines · Daeseok Youn
After
spin_lock()is called, all of if-else conditions in this brace should reach the end of else andspin_unlock()must be called. So It doesn't need to callspin_unlock()without a return statement for handling an error.Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlockSigned-off-by Daeseok Youn <[email protected]>
This patch doesn't apply to my tree, can you please redo it against linux-next and resend it so that I can apply it?
thanks,
greg k-h
Ok.
I will make a patch based on linux-next branch and send it again. Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH <[email protected]>:
Quoted 19 lines · Daeseok Youn
Quoted 11 lines
After
spin_lock()is called, all of if-else conditions in this brace should reach the end of else andspin_unlock()must be called. So It doesn't need to callspin_unlock()without a return statement for handling an error.Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlockSigned-off-by Daeseok Youn <[email protected]>This patch doesn't apply to my tree, can you please redo it against linux-next and resend it so that I can apply it?
thanks,
greg k-h