Skip to contentSkip to conversation

video: backlight: gpio-backlight: Add DT support.

PATCH RESEND Superseded Denis Carikli 2 participants 2 messages Feb 26, 2014 – Feb 27, 2014

Subsystems (3)

v11 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v11 1/1 video: backlight: gpio-backlight: Add DT support.

Cc Bryan Wu <[email protected]>
Cc Jingoo Han <[email protected]>
Cc Lee Jones <[email protected]>
Cc Eric Bénard <[email protected]>

---
ChangeLog v11->v11-resend:
- Removed the Cc list because it's only one patch.

ChangeLog v10->v11:
- Shrinked the Cc list.
- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

---
 .../bindings/video/backlight/gpio-backlight.txt    |   19 +++++++
 drivers/video/backlight/gpio_backlight.c           |   60 +++++++++++++++++---
 2 files changed, 72 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +19 -0
new file mode 100644
index 0000000..a923193
@@ -0,0 +1,19 @@
+gpio-backlight bindings
+
+Required properties:
+  - compatible: "gpio-backlight"
+  - gpios: describes the gpio that is used for enabling/disabling the backlight
+    (see GPIO binding[0] for more details).
+
+Optional properties:
+  - default-on: enable the backlight at boot.
+
+[0]: Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+
+	backlight {
+		compatible = "gpio-backlight";
+		gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
+		default-on;
+	};
drivers/video/backlight/gpio_backlight.c +53 -7

112 lines not on this page · raw message

Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 7 lines
Cc Bryan Wu <[email protected]>
Cc Jingoo Han <[email protected]>
Cc Lee Jones <[email protected]>
Cc Eric Bénard <[email protected]>

---
ChangeLog v10->v11:

Wow, that's a lot of fix-ups.

Quoted 1 line

- Shrinked the Cc list.

It's okay to have a large CC list, but I'd do it manually rather than adding a line for each in the commit log. This latter method is good for one or two extra people you wish to add to an individual patch when sending a patch-set.

Quoted 6 lines

- Fixed the of_match_table warning.

ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

Why was it unnecessary?

Quoted 30 lines

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

Quoted 7 lines

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.

---
 .../bindings/video/backlight/gpio-backlight.txt    |   19 +++++++
 drivers/video/backlight/gpio_backlight.c           |   60 +++++++++++++++++---

These should really be in a seperate patch.

Quoted 9 lines
 2 files changed, 72 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +0 -0
new file mode 100644
index 0000000..a923193

Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt line 6

Quoted 6 lines
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +6 -0
@@ -0,0 +1,19 @@
+gpio-backlight bindings
+
+Required properties:
+  - compatible: "gpio-backlight"
+  - gpios: describes the gpio that is used for enabling/disabling the backlight
+    (see GPIO binding[0] for more details).

The format of the [0] is confusing and it doesn't really add anything here. If you wish to reverence an external binding document just write out the path. Failing that [bindings]/gpio/gpio.txt also works.

Quoted 13 lines
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +12 -0
+Optional properties:
+  - default-on: enable the backlight at boot.
+
+[0]: Documentation/devicetree/bindings/gpio/gpio.txt
+
+Example:
+
+	backlight {
+		compatible = "gpio-backlight";
+		gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
+		default-on;
+	};
drivers/video/backlight/gpio_backlight.c +0 -0

<snip>

drivers/video/backlight/gpio_backlight.c static const struct backlight_ops gpio_backlight_ops = { · line 71

Quoted 6 lines
drivers/video/backlight/gpio_backlight.c +6 -0
+static int gpio_backlight_probe_dt(struct platform_device *pdev,
+				   struct gpio_backlight *gbl)
+{
+	struct device_node *np = pdev->dev.of_node;
+	enum of_gpio_flags gpio_flags;
+	bool default_on = false;

There's no need to initialise this.

drivers/video/backlight/gpio_backlight.c static const struct backlight_ops gpio_backlight_ops = { · line 73

Quoted 1 line
drivers/video/backlight/gpio_backlight.c +1 -0
+	gbl->fbdev = NULL;

This will already be NULL, as you used kzalloc().

drivers/video/backlight/gpio_backlight.c static const struct backlight_ops gpio_backlight_ops = { · line 88

Quoted 3 lines
drivers/video/backlight/gpio_backlight.c +3 -0
+	default_on = of_property_read_bool(np, "default-on");
+
+	gbl->def_value = default_on;

Why complicate matters?

        gbl->def_value = of_property_read_bool(np, "default-on");

drivers/video/backlight/gpio_backlight.c static int gpio_backlight_probe(struct platform_device *pdev) · line 146

Quoted 2 lines
drivers/video/backlight/gpio_backlight.c +1 -1
-	bl->props.brightness = pdata->def_value;
+	bl->props.brightness = gbl->def_value;

Do you use gbl->def_value again later? If not:

        gbl->def_value = = of_property_read_bool(np, "default-on");

#ifdef CONFIG_OF ?

drivers/video/backlight/gpio_backlight.c static int gpio_backlight_probe(struct platform_device *pdev) · line 157

Quoted 5 lines
drivers/video/backlight/gpio_backlight.c +5 -0
+static struct of_device_id gpio_backlight_of_match[] = {
+	{ .compatible = "gpio-backlight" },
+	{ /* sentinel */ }
+};
+

#endif ?

drivers/video/backlight/gpio_backlight.c static int gpio_backlight_probe(struct platform_device *pdev) · line 162

Quoted 5 lines

static struct platform_driver gpio_backlight_driver = {

drivers/video/backlight/gpio_backlight.c +1 -0
 	.driver		= {
 		.name		= "gpio-backlight",
 		.owner		= THIS_MODULE,
+		.of_match_table = gpio_backlight_of_match,

of_match_ptr() ?

<snip>

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog