Skip to contentSkip to conversation

staging:rtl8192e: check return value of dev_skb_alloc

PATCH In review Nicholas Krause 2 participants 2 messages Jun 18, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 staging:rtl8192e: check return value of dev_skb_alloc

drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2 -0
index 1a95d1f..1a90546 100644
@@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		}
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (!skb)
+			!return rt_status;
 		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;

--

maintainer
#1 lore raw
Quoted 5 lines · Nicholas Krause
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +0 -0
index 1a95d1f..1a90546 100644

drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,

Quoted 9 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2 -1
@@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		}
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (!skb)
+			!return rt_status;
 		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;
--

This is a joke now, right?

I'm going to give you a bit of time to step back, relax, and think about what you are doing. Feel free to come back next week with a fixed and correct patch when you go and read my previous review comments.

greg k-h