drm/i915: remove pixel doubled HDMI modes from valid modes list
Subsystems (2)
PATCH 1/1 drm/i915: remove pixel doubled HDMI modes from valid modes list
From: Clint Taylor <[email protected]>
Intel HDMI does not correctly configure pixel replicated HDMI modes 480i and 576i. Remove support for these modes until DRM has been changed to correctly identify SD interlaced modes by reporting there true horizontal resolution 720 instead of the pre-pixel doubled 1440.
--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ; +if (mode->flags &DRM_MODE_FLAG_DBLCLK ) +return MODE_NO_INTERLACE ; +return MODE_OK ; }
Signature · 1 line
1.7.9.5
Quoted 17 lines · On Mon, Aug 11, 2014 at 03:33:02PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
Intel HDMI does not correctly configure pixel replicated HDMI modes 480i and 576i. Remove support for these modes until DRM has been changed to correctly identify SD interlaced modes by reporting there true horizontal resolution 720 instead of the pre-pixel doubled 1440.
Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/intel_hdmi.c +0
-0
drivers/gpu/drm/i915/intel_hdmi.c intel_hdmi_mode_valid(struct drm_connector *connector, · line 875
Quoted 3 lines
drivers/gpu/drm/i915/intel_hdmi.c +0
-0@@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ;
If it is just a workaround for a drm bug. You need a big comment explaining why you w/a rather than pressing for the bug fix.
Quoted 3 lines
drivers/gpu/drm/i915/intel_hdmi.c +3
-0+if (mode->flags &DRM_MODE_FLAG_DBLCLK ) +return MODE_NO_INTERLACE ; +
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 13 lines · Chris Wilson
Quoted 12 lines · On Mon, Aug 11, 2014 at 03:33:02PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
Intel HDMI does not correctly configure pixel replicated HDMI modes 480i and 576i. Remove support for these modes until DRM has been changed to correctly identify SD interlaced modes by reporting there true horizontal resolution 720 instead of the pre-pixel doubled 1440.
Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)
Quoted 11 lines
drivers/gpu/drm/i915/intel_hdmi.c intel_hdmi_mode_valid(struct drm_connector *connector, · line 875
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +0
-0@@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ;If it is just a workaround for a drm bug. You need a big comment explaining why you w/a rather than pressing for the bug fix.
Well there's a very small chance I'll take this anyway - if the drm core is broken we need to take out the mode from the drm core, not here. -Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 26 lines · Daniel Vetter
Quoted 13 lines · Chris Wilson
Quoted 12 lines · On Mon, Aug 11, 2014 at 03:33:02PM -0700, [email protected] wrote:
From: Clint Taylor <[email protected]>
Intel HDMI does not correctly configure pixel replicated HDMI modes 480i and 576i. Remove support for these modes until DRM has been changed to correctly identify SD interlaced modes by reporting there true horizontal resolution 720 instead of the pre-pixel doubled 1440.
Signed-off-by Clint Taylor <[email protected]>--- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+)Quoted 11 lines
drivers/gpu/drm/i915/intel_hdmi.c intel_hdmi_mode_valid(struct drm_connector *connector, · line 875
Quoted 8 lines
drivers/gpu/drm/i915/intel_hdmi.c +0
-0@@ -873,6 +873,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ;If it is just a workaround for a drm bug. You need a big comment explaining why you w/a rather than pressing for the bug fix.
Quoted 4 lines
Well there's a very small chance I'll take this anyway - if the drm core is broken we need to take out the mode from the drm core, not here. -Daniel
Agreed this is not the correct solution to fix the issue. Advertising that we support bad geometry is also incorrect.
Clint