Skip to contentSkip to conversation

libpfm4: needs NPTL support

PATCH Superseded Alexey Brodkin 2 participants 2 messages Sep 18, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libpfm4: needs NPTL support

Fixes following build failure when tools use Linux threads instead of NPTL:
--->---
self_smpl_multi.c: In function 'my_thread':
self_smpl_multi.c:354:2: error: implicit declaration of function 'pthread_barrier_wait' [-Werror=implicit-function-declaration]
pthread_barrier_wait(&barrier);
^
self_smpl_multi.c: In function 'main':
self_smpl_multi.c:450:2: error: implicit declaration of function 'pthread_barrier_init' [-Werror=implicit-function-declaration]
pthread_barrier_init(&barrier, 0, max_thr+1);
^
cc1: all warnings being treated as errors
--->---

Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/libpfm4/Config.in | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/libpfm4/Config.in +3 -4
index 86ca8f6..91b56a3 100644
@@ -2,13 +2,12 @@ config BR2_PACKAGE_LIBPFM4
 	bool "libpfm4"
 	depends on !BR2_avr32 # no perf_event_open
 	depends on !BR2_xtensa && !BR2_bfin # no nptl or linuxthreads (new)
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	help
 	  A helper library to help encode Performance Events to use with
 	  Operating system kernels performance monitoring interfaces.
 
 	  http://perfmon2.sourceforge.net/
 
-comment "libpfm4 needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_avr32 && !BR2_xtensa && !BR2_bfin
+comment "libpfm4 needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 libpfm4: needs NPTL support

Hi Alexey,

Quoted 26 lines · Alexey Brodkin

Fixes following build failure when tools use Linux threads instead of NPTL:
--->---
self_smpl_multi.c: In function 'my_thread':
self_smpl_multi.c:354:2: error: implicit declaration of function 'pthread_barrier_wait' [-Werror=implicit-function-declaration]
pthread_barrier_wait(&barrier);
^
self_smpl_multi.c: In function 'main':
self_smpl_multi.c:450:2: error: implicit declaration of function 'pthread_barrier_init' [-Werror=implicit-function-declaration]
pthread_barrier_init(&barrier, 0, max_thr+1);
^
cc1: all warnings being treated as errors
--->---

Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/libpfm4/Config.in | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
package/libpfm4/Config.in +0 -0
index 86ca8f6..91b56a3 100644

package/libpfm4/Config.in config BR2_PACKAGE_LIBPFM4 · line 4

Quoted 3 lines
package/libpfm4/Config.in +0 -0
@@ -2,13 +2,12 @@ config BR2_PACKAGE_LIBPFM4
 	bool "libpfm4"
 	depends on !BR2_avr32 # no perf_event_open
 	depends on !BR2_xtensa && !BR2_bfin # no nptl or linuxthreads (new)

You can remove this line as well.

package/libpfm4/Config.in config BR2_PACKAGE_LIBPFM4 · line 13

Quoted 13 lines
package/libpfm4/Config.in +3 -4
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	help
 	  A helper library to help encode Performance Events to use with
 	  Operating system kernels performance monitoring interfaces.
 
 	  http://perfmon2.sourceforge.net/
 
-comment "libpfm4 needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_avr32 && !BR2_xtensa && !BR2_bfin
+comment "libpfm4 needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL

Strictly speaking the !BR2_avr32 dependency is not related to NPTL, so it should stay. avr32 support is deprecated and should be removed soon anyway, so I'm not sure it's worth the hassle.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -