Skip to contentSkip to conversation

r8169: fix an if condition

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 19, 2014 – Sep 22, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 r8169: fix an if condition

There is an extra semi-colon so __rtl8169_set_features() is called every time.

Fixes 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
drivers/net/ethernet/realtek/r8169.c +1 -1
index 3027f4a..1d81238 100644
@@ -1882,7 +1882,7 @@ static int rtl8169_set_features(struct net_device *dev,
 	features &= NETIF_F_RXALL | NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_RX;
 
 	rtl_lock_work(tp);
-	if (features ^ dev->features);
+	if (features ^ dev->features)
 		__rtl8169_set_features(dev, features);
 	rtl_unlock_work(tp);