r8169: fix an if condition
PATCH 1/1 r8169: fix an if condition
There is an extra semi-colon so __rtl8169_set_features() is called every time.
Fixes 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/realtek/r8169.c +1 -1
@@ -1882,7 +1882,7 @@ static int rtl8169_set_features(struct net_device *dev, features &=NETIF_F_RXALL |NETIF_F_RXCSUM |NETIF_F_HW_VLAN_CTAG_RX ;rtl_lock_work (tp); -if (features ^ dev->features); +if (features ^ dev->features)__rtl8169_set_features (dev, features);rtl_unlock_work (tp);
From: Dan Carpenter [mailto:[email protected]]
Quoted 1 line
Sent: Friday, September 19, 2014 6:40 PM
[...]
Quoted 3 lines
There is an extra semi-colon so
__rtl8169_set_features()is called every
time.
Acked-by Hayes Wang <[email protected]>
From: Dan Carpenter <[email protected]>
Date: Fri, 19 Sep 2014 13:40:25 +0300
Quoted 5 lines
There is an extra semi-colon so
__rtl8169_set_features()is called every time.Fixes 929a031dfd62 ('r8169: adjust __rtl8169_set_features')Signed-off-by Dan Carpenter <[email protected]>
Dan, this bug exists in 'net' so that is what you should have targetted this tree at.
Applied, thanks.