Skip to contentSkip to conversation

perf/x86: Fix compile warnings for intel_uncore

tip:perf/urgent Andi Kleen 2 participants 3 messages Oct 28, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw

Review

Quoted 2 lines
(quoted diff) +2 -0
+config PERF_EVENTS_INTEL_UNCORE
+	def_bool y

Why not give it a user name? It should be user configurable.

Review

Quoted 1 line
(quoted diff) +1 -0
+	depends on PERF_EVENTS && SUP_SUP_INTEL && PCI

SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL

I suspect you disabled it completely.

-Andi

#2 lore raw
Quoted 4 lines · Andi Kleen

Review

Quoted 2 lines
(quoted diff) +2 -0
+config PERF_EVENTS_INTEL_UNCORE
+	def_bool y

Why not give it a user name? It should be user configurable.

To avoid just that, another more or less pointless config option.

Quoted 5 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	depends on PERF_EVENTS && SUP_SUP_INTEL && PCI

SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL

I suspect you disabled it completely.

Indeed, typo there.

author
#3 lore raw
Quoted 7 lines · Peter Zijlstra
Quoted 4 lines · Andi Kleen

Review

Quoted 2 lines
(quoted diff) +2 -0
+config PERF_EVENTS_INTEL_UNCORE
+	def_bool y

Why not give it a user name? It should be user configurable.

To avoid just that, another more or less pointless config option.

Good point. We should default to allyesconfig, because obviously everyone needs everything.

-Andi