perf/x86: Fix compile warnings for intel_uncore
Review
Quoted 2 lines
(quoted diff) +2
-0+config PERF_EVENTS_INTEL_UNCORE + def_bool y
Why not give it a user name? It should be user configurable.
Review
Quoted 1 line
(quoted diff) +1
-0+ depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
I suspect you disabled it completely.
-Andi
Quoted 4 lines · Andi Kleen
Review
Quoted 2 lines
(quoted diff) +2
-0+config PERF_EVENTS_INTEL_UNCORE + def_bool yWhy not give it a user name? It should be user configurable.
To avoid just that, another more or less pointless config option.
Quoted 5 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
SUP_SUP_INTELlooks wrong. Should beCPU_SUP_INTELI suspect you disabled it completely.
Indeed, typo there.
Quoted 7 lines · Peter Zijlstra
Quoted 4 lines · Andi Kleen
Review
Quoted 2 lines
(quoted diff) +2
-0+config PERF_EVENTS_INTEL_UNCORE + def_bool yWhy not give it a user name? It should be user configurable.
To avoid just that, another more or less pointless config option.
Good point. We should default to allyesconfig, because obviously everyone needs everything.
-Andi