mpt2sas: issue reset is not uninitialized

The issue_reset variables were never set to zero. This bug was found with static analysis.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/mpt2sas/mpt2sas_base.c +0 -0

index 58e4521..98bd546 100644

drivers/scsi/mpt2sas/mpt2sas_base.c +1 -2

 	int rc;
 	void *request;
 	u16 wait_state_count;

@@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = 0;
 	int rc;
 	void *request;
 	u16 wait_state_count;
--

To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 5 lines · Dan Carpenter

The issue_reset variables were never set to zero. This bug was found with static analysis.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/mpt2sas/mpt2sas_base.c mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc, · line 3239

Quoted 10 lines

drivers/scsi/mpt2sas/mpt2sas_base.c +1 -1

index 58e4521..98bd546 100644
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = 0;

Why not false if it is going to be a boolean?

The issue_reset variables were never set to zero. This bug was found with static analysis.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/mpt2sas/mpt2sas_base.c +1 -1

index 58e4521..98bd546 100644
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = 0;
 	int rc;
 	void *request;
 	u16 wait_state_count;

hi Dan,
just a minor question:

did you forget to mention that you also changed from u8 to bool or was this unintentional ?