ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
PATCH 1/2 ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
--- arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/boot/dts/kirkwood-6192.dtsi +2 -0
@@ -66,6 +66,8 @@ interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1"; status = "disabled"; };
Signature · 1 line
1.7.10.4
Quoted 3 lines · Evgeni Dobrev
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by Evgeni Dobrev <[email protected]>
This should also go to stable.
Andrew
Quoted 25 lines
--- arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm/boot/dts/kirkwood-6192.dtsi +2
-0@@ -66,6 +66,8 @@ interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1"; status = "disabled"; };Signature · 7 lines
1.7.10.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello.
Quoted 1 line · Evgeni Dobrev
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Please wrap the change log likes at 80 characters or less.
Quoted 10 lines
Signed-off-by Evgeni Dobrev <[email protected]>--- arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm/boot/dts/kirkwood-6192.dtsi +0
-0
arch/arm/boot/dts/kirkwood-6192.dtsi line 70
Quoted 5 lines
arch/arm/boot/dts/kirkwood-6192.dtsi +2
-0@@ -66,6 +66,8 @@ interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1";
Please indent with tabs, not spaces.
[...]
WBR, Sergei
Dear Evgeni Dobrev,
Quoted 1 line · Evgeni Dobrev
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Commit log text should be wrapped to some reasonable length.
arch/arm/boot/dts/kirkwood-6192.dtsi line 70
Quoted 5 lines
arch/arm/boot/dts/kirkwood-6192.dtsi +2
-0interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1";
You should use tabs and not spaces for indentation in Device Tree files.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Hello Thomas,
Quoted 7 lines · Thomas Petazzoni
Dear Evgeni Dobrev,
Quoted 1 line · Evgeni Dobrev
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Commit log text should be wrapped to some reasonable length.
I will fix this.
Quoted 8 lines
arch/arm/boot/dts/kirkwood-6192.dtsi line 70
Quoted 6 lines
arch/arm/boot/dts/kirkwood-6192.dtsi +2
-0interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1";You should use tabs and not spaces for indentation in Device Tree files.
I will resubmit. Thank you for your review.
Quoted 9 lines
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --
evgeni
v2 cover ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
In reply to Evgeni Dobrevv2: indent with tabs only
wrap change log at 80 chars
Evgeni Dobrev (1):
enable phy driver for SATA controller on 88f6192
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)
Signature · 1 line
1.7.10.4
PATCH v2 1/1 ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
In reply to Evgeni DobrevThis patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
--- arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/boot/dts/kirkwood-6192.dtsi +2 -0
@@ -66,6 +66,8 @@ interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1"; status = "disabled"; };
Signature · 1 line
1.7.10.4
Quoted 4 lines · Evgeni Dobrev
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by Evgeni Dobrev <[email protected]>
Hi Evgeni
Added to mvebu/dt
Andrew
Quoted 25 lines
--- arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm/boot/dts/kirkwood-6192.dtsi +2
-0@@ -66,6 +66,8 @@ interrupts = <21>; clocks = <&gate_clk 14>, <&gate_clk 15>; clock-names = "0", "1"; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1"; status = "disabled"; };Signature · 7 lines
1.7.10.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel