Skip to contentSkip to conversation

staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

PATCH In review Heba Aamer 2 participants 2 messages Jan 26, 2015 – Jan 27, 2015 Staging

lore
Share & tools
lore

Heba Aamer

author
#0 lore raw

PATCH v2 1/1 staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

---
v2: changed netdev_info to pr_info

 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +1 -1
index 7d0d171..15f0d42 100644
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
-	printk(KERN_INFO "r8712u: Staging version\n");
+	pr_info("r8712u: Staging version\n");
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.
Signature · 1 line
1.7.9.5
#1 lore raw

The subject line is too long.

drivers/staging/rtl8712/usb_intf.c static int r871xu_drv_init(struct usb_interface *pusb_intf, · line 369

Quoted 2 lines
drivers/staging/rtl8712/usb_intf.c +1 -1
-	printk(KERN_INFO "r8712u: Staging version\n");
+	pr_info("r8712u: Staging version\n");

This is a dumb thing to print. Just delete this line.

regards,
dan carpenter