rtl2832: remove compiler warning
Subsystems (2)
PATCH 1/1 rtl2832: remove compiler warning
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.
--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/rtl2832.c +1 -1
@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;dev_dbg (&client->dev,"\n" );
Signature · 1 line
2.1.0
Quoted 28 lines · Luis de Bethencourt
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;dev_dbg (&client->dev,"\n" );Signature · 1 line
2.1.0
Hello all :)
This warning can be seen in:
http://hverkuil.home.xs4all.nl/logs/Saturday.log
Thank you Hans for the daily build and logs.
Luis
Quoted 17 lines · Luis de Bethencourt
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +0
-0
drivers/media/dvb-frontends/rtl2832.c static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) · line 690
Quoted 7 lines
drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;dev_dbg (&client->dev,"\n" );
I looked the code and I cannot see how it could used as uninitialized. Dunno how it could be fixed properly.
Also, I think idiom to say compiler that variable could be uninitialized is to store its own value. But I am fine with zero initialization too.
u32 tmp = tmp;
regards
Antti
Signature · 1 line
http://palosaari.fi/
Quoted 24 lines · Antti Palosaari
Quoted 23 lines · Luis de Bethencourt
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;
Quoted 4 lines
drivers/media/dvb-frontends/rtl2832.c static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) · line 690
Quoted 1 line
drivers/media/dvb-frontends/rtl2832.c +0
-0dev_dbg (&client->dev,"\n" );I looked the code and I cannot see how it could used as uninitialized. Dunno how it could be fixed properly.
Hi Antti,
I agree. If rtl2832_rd_demod_reg() in line 696 doesn't set tmp it is because it has errored out. Which means rtl2832_read_status() itself will goto err before the check for 'if (tmp == 11)' line that generates the warning.
I mentioned this in my commit message :)
Quoted 11 lines
Also, I think idiom to say compiler that variable could be uninitialized is to store its own value. But I am fine with zero initialization too.
u32 tmp = tmp;
regards
AnttiSignature · 1 line
http://palosaari.fi/
If you prefer I use the 'u32 tmp = tmp;' I am happy to change my patch. You say you are fine with zero initialization too, but I prefer offering whatever you think is best.
Thanks for taking the time to look at this,
Luis
Em Tue, 10 Feb 2015 12:57:24 +0200
Antti Palosaari <[email protected]> escreveu:
Quoted 29 lines · Luis de Bethencourt
Quoted 17 lines
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +0
-0drivers/media/dvb-frontends/rtl2832.c static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) · line 690
Quoted 7 lines
drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;dev_dbg (&client->dev,"\n" );I looked the code and I cannot see how it could used as uninitialized. Dunno how it could be fixed properly.
Quoted 4 lines
Also, I think idiom to say compiler that variable could be uninitialized is to store its own value. But I am fine with zero initialization too.
u32 tmp = tmp;
Actually, the right way is to declare it as:
u32 uninitialized_var(tmp)
The syntax to suppress compiler warnings depends on the compiler:
include/linux/compiler-clang.h:#define uninitialized_var(x) x = *(&(x)) include/linux/compiler-gcc.h:#define uninitialized_var(x) x = x
Also, using uninitialized_var() better documents it.
Regards,
Mauro
Quoted 43 lines · Mauro Carvalho Chehab
Em Tue, 10 Feb 2015 12:57:24 +0200
Antti Palosaari <[email protected]> escreveu:Quoted 29 lines · Luis de Bethencourt
Quoted 17 lines
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +0
-0drivers/media/dvb-frontends/rtl2832.c static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) · line 690
Quoted 7 lines
drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 tmp =0 ;dev_dbg (&client->dev,"\n" );I looked the code and I cannot see how it could used as uninitialized. Dunno how it could be fixed properly.
Quoted 4 lines
Also, I think idiom to say compiler that variable could be uninitialized is to store its own value. But I am fine with zero initialization too.
u32 tmp = tmp;
Actually, the right way is to declare it as:
u32
uninitialized_var(tmp)The syntax to suppress compiler warnings depends on the compiler:
Quoted 7 lines
include/linux/compiler-clang.h:#define
uninitialized_var(x)x = *(&(x)) include/linux/compiler-gcc.h:#defineuninitialized_var(x)x = xAlso, using
uninitialized_var()better documents it.Regards,
Mauro
Hi Mauro,
That is a way more elegant solution. Great!
I will check out that compiler-clang header file, it's interesting.
I just sent a revised patch using this :)
Thanks,
Luis