Show proper respect for Heinrich Hertz by using the correct unit for frequency
Subsystems (11)
PATCH 1/1 Show proper respect for Heinrich Hertz by using the correct unit for frequency
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.
---
There are other instances in drivers/ that really need to be fixed as well.
arch/arm/boot/dts/exynos5260-xyref5260.dts | 2 +- arch/arm/boot/dts/omap3-cm-t3517.dts | 2 +- arch/arm/mach-davinci/include/mach/da8xx.h | 2 +- arch/arm/mach-imx/clk-imx6sx.c | 4 ++-- arch/arm/mach-iop13xx/include/mach/time.h | 2 +- arch/arm/mach-ixp4xx/include/mach/platform.h | 2 +- arch/arm/mach-ks8695/include/mach/hardware.h | 2 +- arch/arm/mach-omap2/gpmc-onenand.c | 4 ++-- arch/arm/mach-omap2/hsmmc.c | 2 +- arch/arm/mach-omap2/opp2430_data.c | 4 ++-- arch/arm/mach-omap2/sdrc2xxx.c | 2 +- arch/arm/mach-omap2/sram242x.S | 2 +- arch/arm/mach-omap2/sram243x.S | 2 +- arch/arm/mach-pxa/mp900.c | 2 +- 14 files changed, 17 insertions(+), 17 deletions(-)
arch/arm/boot/dts/exynos5260-xyref5260.dts +1 -1
@@ -70,7 +70,7 @@ broken-cd; bypass-smu; cap-mmc-highspeed; - supports-hs200-mode; /* 200 Mhz */ + supports-hs200-mode; /* 200 MHz */ card-detect-delay = <200>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>;
arch/arm/boot/dts/omap3-cm-t3517.dts +1 -1
@@ -66,7 +66,7 @@ otg_drv_vbus: pinmux_otg_drv_vbus { pinctrl-single,pins = < - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */ >; };
arch/arm/mach-davinci/include/mach/da8xx.h +1 -1
@@ -36,7 +36,7 @@ extern void __iomem *da8xx_syscfg1_base;/* * If the DA850/OMAP-L138/AM18x SoC on board is of a higher speed grade -* (than the regular 300Mhz variant), the board code should set this up +* (than the regular 300MHz variant), the board code should set this up * with the supported speed before calling da850_register_cpufreq(). */ extern unsigned int da850_max_speed;
arch/arm/mach-imx/clk-imx6sx.c +2 -2
@@ -216,7 +216,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) clks[IMX6SX_CLK_USBPHY1_GATE ] =imx_clk_gate ("usbphy1_gate" ,"dummy" , base +0x10 ,6 ); clks[IMX6SX_CLK_USBPHY2_GATE ] =imx_clk_gate ("usbphy2_gate" ,"dummy" , base +0x20 ,6 ); -/* FIXME 100Mhz is used for pcie ref for all imx6 pcie, excepted imx6q */ +/* FIXME 100MHz is used for pcie ref for all imx6 pcie, excepted imx6q */ clks[IMX6SX_CLK_PCIE_REF ] =imx_clk_fixed_factor ("pcie_ref" ,"pll6_enet" ,1 ,5 ); clks[IMX6SX_CLK_PCIE_REF_125M ] =imx_clk_gate ("pcie_ref_125m" ,"pcie_ref" , base +0xe0 ,19 );
@@ -520,7 +520,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)pr_err ("Failed to set pcie parent clk.\n" );/* -* Init enet system AHB clock, set to 200Mhz +* Init enet system AHB clock, set to 200MHz * pll2_pfd2_396m-> ENET_PODF-> ENET_AHB */ clk_set_parent (clks[IMX6SX_CLK_ENET_PRE_SEL ], clks[IMX6SX_CLK_PLL2_PFD2 ]);
arch/arm/mach-iop13xx/include/mach/time.h +1 -1
@@ -42,7 +42,7 @@ static inline unsigned long iop13xx_core_freq(void)case IOP13XX_CORE_FREQ_1200 :return 1200000000 ;default : -printk ("%s: warning unknown frequency, defaulting to 800Mhz\n" , +printk ("%s: warning unknown frequency, defaulting to 800MHz\n" , __func__); }
arch/arm/mach-ixp4xx/include/mach/platform.h +1 -1
@@ -74,7 +74,7 @@ extern unsigned long ixp4xx_exp_bus_size;/* * Clock Speed Definitions. */ -#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66Mhzi APB BUS */ +#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66MHzi APB BUS */ #define IXP4XX_UART_XTAL 14745600/*
arch/arm/mach-ks8695/include/mach/hardware.h +1 -1
@@ -17,7 +17,7 @@#include <asm/sizes.h> /* -* Clocks are derived from MCLK, which is 25Mhz +* Clocks are derived from MCLK, which is 25MHz */ #define KS8695_CLOCK_RATE 25000000
arch/arm/mach-omap2/gpmc-onenand.c +2 -2
@@ -216,11 +216,11 @@ static void omap2_onenand_calc_sync_timings(struct gpmc_timings *t, div =gpmc_calc_divider (min_gpmc_clk_period); gpmc_clk_ns =gpmc_ticks_to_ns (div); -if (gpmc_clk_ns <15 )/* >66Mhz */ +if (gpmc_clk_ns <15 )/* >66MHz */ onenand_flags |=ONENAND_FLAG_HF ;else onenand_flags &= ~ONENAND_FLAG_HF ; -if (gpmc_clk_ns <12 )/* >83Mhz */ +if (gpmc_clk_ns <12 )/* >83MHz */ onenand_flags |=ONENAND_FLAG_VHF ;else onenand_flags &= ~ONENAND_FLAG_VHF ;
arch/arm/mach-omap2/hsmmc.c +1 -1
@@ -70,7 +70,7 @@ static void omap_hsmmc1_before_set_reg(struct device *dev, reg =omap_ctrl_readl (control_pbias_offset);if (cpu_is_omap3630 ()) { -/* Set MMC I/O to 52Mhz */ +/* Set MMC I/O to 52MHz */ prog_io =omap_ctrl_readl (OMAP343X_CONTROL_PROG_IO1 ); prog_io |=OMAP3630_PRG_SDMMC1_SPEEDCTRL ;omap_ctrl_writel (prog_io,OMAP343X_CONTROL_PROG_IO1 );
arch/arm/mach-omap2/opp2430_data.c +2 -2
@@ -116,7 +116,7 @@ const struct prcm_config omap2430_rate_table[] = { RATE_IN_243X},/* PRCM-boot/bypass */ - {S13M ,S13M ,S13M ,RB_CM_CLKSEL_MPU_VAL ,/* 13Mhz */ + {S13M ,S13M ,S13M ,RB_CM_CLKSEL_MPU_VAL ,/* 13MHz */ RB_CM_CLKSEL_DSP_VAL ,RB_CM_CLKSEL_GFX_VAL ,RB_CM_CLKSEL1_CORE_VAL ,MB_CM_CLKSEL1_PLL_13_VAL , MX_CLKSEL2_PLL_2x_VAL, RB_CM_CLKSEL_MDM_VAL,
@@ -124,7 +124,7 @@ const struct prcm_config omap2430_rate_table[] = { RATE_IN_243X},/* PRCM-boot/bypass */ - {S12M ,S12M ,S12M ,RB_CM_CLKSEL_MPU_VAL ,/* 12Mhz */ + {S12M ,S12M ,S12M ,RB_CM_CLKSEL_MPU_VAL ,/* 12MHz */ RB_CM_CLKSEL_DSP_VAL ,RB_CM_CLKSEL_GFX_VAL ,RB_CM_CLKSEL1_CORE_VAL ,MB_CM_CLKSEL1_PLL_12_VAL , MX_CLKSEL2_PLL_2x_VAL, RB_CM_CLKSEL_MDM_VAL,
arch/arm/mach-omap2/sdrc2xxx.c +1 -1
@@ -164,6 +164,6 @@ void omap2xxx_sdrc_init_params(u32 force_lock_to_unlock_mode) mem_timings.slow_dll_ctrl |= ((mem_timings.fast_dll_ctrl &0xF ) | (1 <<2 )); -/* 90 degree phase for anything below 133Mhz + disable DLL filter */ +/* 90 degree phase for anything below 133MHz + disable DLL filter */ mem_timings.slow_dll_ctrl |= ((1 <<1 ) | (3 <<8 )); }
arch/arm/mach-omap2/sram242x.S +1 -1
@@ -64,7 +64,7 @@ ENTRY(omap242x_sram_ddr_init) mvn r9, #0x4 @ mask to get clear bit2 and r10, r10, r9 @ clear bit2 for lock mode. orr r10, r10, #0x8 @ make sure DLL on (es2 bit pos) - orr r10, r10, #0x2 @ 90 degree phase for all below 133Mhz + orr r10, r10, #0x2 @ 90 degree phase for all below 133MHz str r10, [r11] @ commit to DLLA_CTRL bl i_dll_wait @ wait for dll to lock
arch/arm/mach-omap2/sram243x.S +1 -1
@@ -64,7 +64,7 @@ ENTRY(omap243x_sram_ddr_init) mvn r9, #0x4 @ mask to get clear bit2 and r10, r10, r9 @ clear bit2 for lock mode. orr r10, r10, #0x8 @ make sure DLL on (es2 bit pos) - orr r10, r10, #0x2 @ 90 degree phase for all below 133Mhz + orr r10, r10, #0x2 @ 90 degree phase for all below 133MHz str r10, [r11] @ commit to DLLA_CTRL bl i_dll_wait @ wait for dll to lock
arch/arm/mach-pxa/mp900.c +1 -1
@@ -28,7 +28,7 @@static void isp116x_pfm_delay (struct device *dev,int delay) { -/* 400Mhz PXA2 = 2.5ns / instruction */ +/* 400MHz PXA2 = 2.5ns / instruction */ int cyc = delay /10 ;
Signature · 2 lines
FTTC broadband for 0.8mile line: [email protected] down 400kbps up according to speedtest.net.
Hi!
Quoted 11 lines
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.
arch/arm/mach-ixp4xx/include/mach/platform.h extern unsigned long ixp4xx_exp_bus_size; · line 79
Quoted 7 lines
arch/arm/mach-ixp4xx/include/mach/platform.h +1
-1@@ -74,7 +74,7 @@ extern unsigned long ixp4xx_exp_bus_size;/* * Clock Speed Definitions. */ -#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66Mhzi APB BUS */ +#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66MHzi APB BUS */ #define IXP4XX_UART_XTAL 14745600
Speaking about meaningless... What is MHzi supposed to mean?
ACK for the rest.
Signature · 7 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
A message that is not in the archive (sent off-list or not yet received): 20150511131952.GD2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org
Hi!
Quoted 11 lines
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.
arch/arm/mach-ixp4xx/include/mach/platform.h extern unsigned long ixp4xx_exp_bus_size; · line 79
Quoted 7 lines
arch/arm/mach-ixp4xx/include/mach/platform.h +1
-1@@ -74,7 +74,7 @@ extern unsigned long ixp4xx_exp_bus_size;/* * Clock Speed Definitions. */ -#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66Mhzi APB BUS */ +#define IXP4XX_PERIPHERAL_BUS_CLOCK (66)/* 66MHzi APB BUS */ #define IXP4XX_UART_XTAL 14745600
Speaking about meaningless... What is MHzi supposed to mean?
ACK for the rest.
Signature · 6 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Russell King - ARM Linux
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.Signed-off-by Russell King <[email protected]>
Quoted 11 lines · Tony Lindgren
Quoted 8 lines · Russell King - ARM Linux
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.Signed-off-by Russell King <[email protected]>Acked-by Tony Lindgren <[email protected]>
Cheers.
Signature · 1 line
Robert
Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux:
Quoted 8 lines
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.Signed-off-by Russell King <[email protected]>
Nice. :) Since you're being exact, should it be "Hertz' contribution"?
arch/arm/boot/dts/omap3-cm-t3517.dts line 69
Quoted 10 lines
arch/arm/boot/dts/omap3-cm-t3517.dts +1
-1@@ -66,7 +66,7 @@ otg_drv_vbus: pinmux_otg_drv_vbus { pinctrl-single,pins = < - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */
This one looks like an identifier - did you check where it comes from and whether it needs to be fixed there as well?
arch/arm/boot/dts/omap3-cm-t3517.dts line 72
Quoted 3 lines
arch/arm/boot/dts/omap3-cm-t3517.dts +0
-0>; };
Rest looks good,
Cheers,
Andreas
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg)
Quoted 18 lines · Andreas F?rber
Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux:
Quoted 8 lines
The SI unit of frequency is Hertz, named after Heinrich Hertz, and is given the symbol "Hz" to denote this. "hz" is not the unit of frequency, and is in fact meaningless.
Fix
arch/armto correctly use "Hz", thereby acknowledging Heinrich Hertz contribution to the modern world.Signed-off-by Russell King <[email protected]>Nice. :) Since you're being exact, should it be "Hertz' contribution"?
Quoted 6 lines
arch/arm/boot/dts/omap3-cm-t3517.dts +0
-0@@ -66,7 +66,7 @@
Quoted 7 lines
arch/arm/boot/dts/omap3-cm-t3517.dts line 69
Quoted 4 lines
arch/arm/boot/dts/omap3-cm-t3517.dts +1
-1otg_drv_vbus: pinmux_otg_drv_vbus { pinctrl-single,pins = < - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */This one looks like an identifier - did you check where it comes from and whether it needs to be fixed there as well?
There isn't any other reference to it in arch/arm (if there were, the grep to find these would itself have found it.)
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.