drm/amdgpu: information leak in amdgpu_info_ioctl()
Subsystems (3)
PATCH 1/1 drm/amdgpu: information leak in amdgpu_info_ioctl()
We recently changed the drm_amdgpu_info_device struct so now there is a 4 byte hole at the end. We need to initialize it so we don't disclose secret information from the stack.
Fixes fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -1
@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_filereturn n ? -EFAULT :0 ; }case AMDGPU_INFO_DEV_INFO : { -struct drm_amdgpu_info_device dev_info; +struct drm_amdgpu_info_device dev_info = {};struct amdgpu_cu_info cu_info; dev_info.device_id = dev->pdev->device;
Alex Deucher
AppliedQuoted 6 lines · Dan Carpenter
We recently changed the
drm_amdgpu_info_devicestruct so now there is a 4 byte hole at the end. We need to initialize it so we don't disclose secret information from the stack.Fixes fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')Signed-off-by Dan Carpenter <[email protected]>
Applied. thanks!
Alex
Quoted 18 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1
-1@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_filereturn n ? -EFAULT :0 ; }case AMDGPU_INFO_DEV_INFO : { -struct drm_amdgpu_info_device dev_info; +struct drm_amdgpu_info_device dev_info = {};struct amdgpu_cu_info cu_info; dev_info.device_id = dev->pdev->device;_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel