Skip to contentSkip to conversation

drm/amdgpu: information leak in amdgpu_info_ioctl()

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 28, 2015 – Jul 29, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: information leak in amdgpu_info_ioctl()

We recently changed the drm_amdgpu_info_device struct so now there is a 4 byte hole at the end. We need to initialize it so we don't disclose secret information from the stack.

Fixes fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -1
index d9de73a..81d60a9 100644
@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
 		return n ? -EFAULT : 0;
 	}
 	case AMDGPU_INFO_DEV_INFO: {
-		struct drm_amdgpu_info_device dev_info;
+		struct drm_amdgpu_info_device dev_info = {};
 		struct amdgpu_cu_info cu_info;
 
 		dev_info.device_id = dev->pdev->device;
Applied
#1 lore raw
Quoted 6 lines · Dan Carpenter

We recently changed the drm_amdgpu_info_device struct so now there is a 4 byte hole at the end. We need to initialize it so we don't disclose secret information from the stack.

Fixes fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')

Applied. thanks!

Alex

Quoted 18 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -1
index d9de73a..81d60a9 100644
@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
                return n ? -EFAULT : 0;
        }
        case AMDGPU_INFO_DEV_INFO: {
-               struct drm_amdgpu_info_device dev_info;
+               struct drm_amdgpu_info_device dev_info = {};
                struct amdgpu_cu_info cu_info;
 
                dev_info.device_id = dev->pdev->device;

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel