Skip to contentSkip to conversation

ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

PATCH In review Luis de Bethencourt 3 participants 4 messages Aug 27, 2015 – Oct 15, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 sound/soc/bcm/bcm2835-i2s.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/bcm/bcm2835-i2s.c +2 -0
index 03fa1cb..8c435be 100644
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
+
 static struct platform_driver bcm2835_i2s_driver = {
 	.probe		= bcm2835_i2s_probe,
 	.driver		= {
Signature · 1 line
2.4.6
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Luis de Bethencourt

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 sound/soc/bcm/bcm2835-i2s.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 13 lines
sound/soc/bcm/bcm2835-i2s.c +2 -0
index 03fa1cb..8c435be 100644
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
+
 static struct platform_driver bcm2835_i2s_driver = {
 	.probe		= bcm2835_i2s_probe,
 	.driver		= {
Acked-by on v1 1/1
#2 lore raw
In reply to Luis de Bethencourt
Quoted 14 lines · Luis de Bethencourt

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 sound/soc/bcm/bcm2835-i2s.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/bcm/bcm2835-i2s.c +0 -0
index 03fa1cb..8c435be 100644

sound/soc/bcm/bcm2835-i2s.c static const struct of_device_id bcm2835_i2s_of_match[] = { · line 869

Quoted 8 lines
sound/soc/bcm/bcm2835-i2s.c +2 -0
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
+
 static struct platform_driver bcm2835_i2s_driver = {
 	.probe		= bcm2835_i2s_probe,
 	.driver		= {

It looks like this should go through the asoc tree, but I don't see it in there.

FWIW, it is also:

#3 lore raw
Quoted 28 lines · Eric Anholt
Quoted 14 lines · Luis de Bethencourt

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 sound/soc/bcm/bcm2835-i2s.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/bcm/bcm2835-i2s.c +0 -0
index 03fa1cb..8c435be 100644

sound/soc/bcm/bcm2835-i2s.c static const struct of_device_id bcm2835_i2s_of_match[] = { · line 869

Quoted 8 lines
sound/soc/bcm/bcm2835-i2s.c +2 -0
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
 	{},
 };
 
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
+
 static struct platform_driver bcm2835_i2s_driver = {
 	.probe		= bcm2835_i2s_probe,
 	.driver		= {

It looks like this should go through the asoc tree, but I don't see it in there.

Quoted 3 lines

FWIW, it is also:

Hi Eric,

Should I resend adding somebody from the asoc tree to the CC?

Thanks for the review,
Luis