ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
Subsystems (4)
PATCH 1/1 ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
--- sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/bcm/bcm2835-i2s.c +2 -0
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, }; +MODULE_DEVICE_TABLE (of, bcm2835_i2s_of_match); +static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = {
Signature · 1 line
2.4.6
Quoted 7 lines · Luis de Bethencourt
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by Luis de Bethencourt <[email protected]>--- sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 13 lines
sound/soc/bcm/bcm2835-i2s.c +2
-0@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, }; +MODULE_DEVICE_TABLE (of, bcm2835_i2s_of_match); +static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = {
Quoted 14 lines · Luis de Bethencourt
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by Luis de Bethencourt <[email protected]>--- sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)sound/soc/bcm/bcm2835-i2s.c +0
-0
sound/soc/bcm/bcm2835-i2s.c static const struct of_device_id bcm2835_i2s_of_match[] = { · line 869
Quoted 8 lines
sound/soc/bcm/bcm2835-i2s.c +2
-0@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, }; +MODULE_DEVICE_TABLE (of, bcm2835_i2s_of_match); +static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = {
It looks like this should go through the asoc tree, but I don't see it in there.
FWIW, it is also:
Quoted 28 lines · Eric Anholt
Quoted 14 lines · Luis de Bethencourt
These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work.
Signed-off-by Luis de Bethencourt <[email protected]>--- sound/soc/bcm/bcm2835-i2s.c | 2 ++ 1 file changed, 2 insertions(+)sound/soc/bcm/bcm2835-i2s.c +0
-0sound/soc/bcm/bcm2835-i2s.c static const struct of_device_id bcm2835_i2s_of_match[] = { · line 869
Quoted 8 lines
sound/soc/bcm/bcm2835-i2s.c +2
-0@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = { {}, }; +MODULE_DEVICE_TABLE (of, bcm2835_i2s_of_match); +static struct platform_driver bcm2835_i2s_driver = { .probe = bcm2835_i2s_probe, .driver = {It looks like this should go through the asoc tree, but I don't see it in there.
Quoted 3 lines
FWIW, it is also:
Acked-by Eric Anholt <[email protected]>
Hi Eric,
Should I resend adding somebody from the asoc tree to the CC?
Thanks for the review,
Luis