Skip to contentSkip to conversation

usb: musb: Fix module autoload for OF platform driver

PATCH Superseded Luis de Bethencourt 2 participants 3 messages Aug 27, 2015

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: musb: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---
 drivers/usb/musb/ux500.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/musb/ux500.c +2 -0
index 39168fe..b2685e7 100644
@@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
         {}
 };
 
+MODULE_DEVICE_TABLE(of, ux500_match);
+
 static struct platform_driver ux500_driver = {
 	.probe		= ux500_probe,
 	.remove		= ux500_remove,
Signature · 1 line
2.4.6
#1 lore raw

Hi,

Quoted 2 lines · Luis de Bethencourt

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'? That helps filtering in git-log.

Thanks,
-Bin.

Quoted 26 lines
---
 drivers/usb/musb/ux500.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/musb/ux500.c +2 -1
index 39168fe..b2685e7 100644
@@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
         {}
 };
 
+MODULE_DEVICE_TABLE(of, ux500_match);
+
 static struct platform_driver ux500_driver = {
        .probe          = ux500_probe,
        .remove         = ux500_remove,
--

2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 4 lines · Bin Liu

Hi,

On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt <[email protected]> wrote:

Quoted 9 lines
Quoted 2 lines

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'? That helps filtering in git-log.

Thanks,
-Bin.

Off course. Sent a second version with 'usb: musb: ux500:' in the commit subject.

Thanks for reviewing,
Luis

Quoted 31 lines
Quoted 22 lines
---
 drivers/usb/musb/ux500.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/musb/ux500.c +2 -1
index 39168fe..b2685e7 100644
@@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
         {}
 };
 
+MODULE_DEVICE_TABLE(of, ux500_match);
+
 static struct platform_driver ux500_driver = {
        .probe          = ux500_probe,
        .remove         = ux500_remove,
--

2.4.6

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/