Skip to contentSkip to conversation

arm64: renesas: Add EXTAL configuration to Salvator-X

RFC PATCH In review Magnus Damm 5 participants 6 messages Sep 8, 2015 – Sep 9, 2015

Subsystems (3)
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

RFC PATCH 1/1 arm64: renesas: Add EXTAL configuration to Salvator-X

From: Magnus Damm <[email protected]>

Configure EXTAL to 16.666 MHz on Salvator-X.

---

This sets the EXTAL frequency for the V9 integration series:
[PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9

To be used with the V7 CPG:
[PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +4 -0
@@ -32,6 +32,10 @@
 	};
 };
 
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
 &pfc {
 	scif1_pins: scif1 {
 		renesas,groups = "scif1_data_a", "scif1_ctrl";
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Configure EXTAL to 16.666 MHz on Salvator-X.

Cfr. "[PATCH 3/3] arm64: renesas: salvator-x: Add missing extal clock override"
http://www.spinics.net/lists/linux-sh/msg44416.html

Signature · 10 lines
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Acked-by on v1 1/1
#2 lore raw
In reply to Magnus Damm

Hi Magnus,

Thank you for the patch.

Quoted 5 lines · On Tuesday 08 September 2015 13:49:57 Magnus Damm wrote:

From: Magnus Damm <[email protected]>

Configure EXTAL to 16.666 MHz on Salvator-X.

This looks quite straightforward and good to me. I don't think it requires the RFC status.

Quoted 24 lines

---

This sets the EXTAL frequency for the V9 integration series:
[PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9

To be used with the V7 CPG:
[PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +0 -0

13:44:53.682366518 +0900 @@ -32,6 +32,10 @@

arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +4 -0
 	};
 };
 
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
 &pfc {
 	scif1_pins: scif1 {
 		renesas,groups = "scif1_data_a", "scif1_ctrl";
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#3 lore raw
In reply to Magnus Damm

Hi Geert,

Quoted 11 lines · Geert Uytterhoeven
Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Configure EXTAL to 16.666 MHz on Salvator-X.

Cfr. "[PATCH 3/3] arm64: renesas: salvator-x: Add missing extal clock override"
http://www.spinics.net/lists/linux-sh/msg44416.html

Thanks, yeah I suspected this was done already. =)

To make things slightly more complicated it seems that some boards use 16.6666 MHz and others 16.0 Mhz...

Cheers,

/ magnus

#4 lore raw
In reply to Magnus Damm

Hi Magnus,

Quoted 2 lines

To make things slightly more complicated it seems that some boards use 16.6666 MHz and others 16.0 Mhz...

AFAIK, the 16.0 Mhz is only available in some initial Salvator-X boards. So, 16.6666 MHz should be standard value, I guess.

#5 lore raw
In reply to Magnus Damm
Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Configure EXTAL to 16.666 MHz on Salvator-X.

Quoted 8 lines

---

This sets the EXTAL frequency for the V9 integration series:
[PATCH v9 00/07][RFC] Renesas R-Car H3 (r8a7795) integration patches V9

To be used with the V7 CPG:
[PATCH v7 00/05] Renesas R-Car Gen3 CPG support V7

Thanks,

I have pushed this patch to the renesas tree in a new topic branch, topic/arm64-rcar-gen3-v9.plus, which is based on topic/arm64-rcar-gen3-v9.

I am assuming you will include this in/squash this into the next posting of "Renesas R-Car H3 (r8a7795) integration patches".

Disclaimer: To be quite clear none of these patches are queued up for mainline yet and as such they are not included in the next or devel branches of the renesas tree.