Skip to contentSkip to conversation

rtptools: needs RPC support

PATCH New Vicente Olivert Riera 3 participants 8 messages Sep 23, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtptools: needs RPC support

rtptools needs a toolchain with RPC support, otherwise it will fail with an error message like this one:

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */

---
 package/rtptools/Config.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
package/rtptools/Config.in +4 -0
index 80bbb7a..a798960 100644
@@ -1,5 +1,9 @@
+comment "rtptools needs a toolchain w/ RPC"
+	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+
 config BR2_PACKAGE_RTPTOOLS
 	bool "rtptools"
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  The rtptools distribution consists of a number of small
 	  applications that can be used for processing RTP data.
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 rtptools: needs RPC support

Dear Vicente Olivert Riera,

Quoted 7 lines · Vicente Olivert Riera

rtptools needs a toolchain with RPC support, otherwise it will fail with an error message like this one:

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */

I'm surprised we have not seen autobuilder failures. Or did you forget to include a reference to an autobuilder error?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 rtptools: needs RPC support

Dear Thomas Petazzoni,

Quoted 6 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 3 lines · Vicente Olivert Riera

rtptools needs a toolchain with RPC support, otherwise it will fail with an error message like this one:

Quoted 7 lines
Quoted 4 lines

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */

I'm surprised we have not seen autobuilder failures. Or did you forget to include a reference to an autobuilder error?

No, I didn't forget that. I have catch this issue with one local autobuilder I have. If you wonder why I have a local autobuilder instead of submitting the results to the ML, it's because that autobuilder uses toolchains that are not yet included in our Buildroot tree.

Regards,

Vincent.

Quoted 5 lines

Thanks!

Thomas

#3 lore raw

PATCH 1/1 rtptools: needs RPC support

Hello,

Quoted 7 lines · Vicente Olivert Riera
Quoted 2 lines

I'm surprised we have not seen autobuilder failures. Or did you forget to include a reference to an autobuilder error?

No, I didn't forget that. I have catch this issue with one local autobuilder I have. If you wonder why I have a local autobuilder instead of submitting the results to the ML, it's because that autobuilder uses toolchains that are not yet included in our Buildroot tree.

That's perfectly OK. However, I wonder why we haven't seen this problem with toolchains already tested in the autobuilders. rtptools does not have any other dependencies, and we have a "basic" toolchain with no special options enabled.

Also, I think your patch should instead be:

select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

and add libtirpc to the dependencies.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 rtptools: needs RPC support

Hi Thomas,

Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Vicente Olivert Riera
Quoted 2 lines

I'm surprised we have not seen autobuilder failures. Or did you forget to include a reference to an autobuilder error?

No, I didn't forget that. I have catch this issue with one local autobuilder I have. If you wonder why I have a local autobuilder instead of submitting the results to the ML, it's because that autobuilder uses toolchains that are not yet included in our Buildroot tree.

Quoted 8 lines

That's perfectly OK. However, I wonder why we haven't seen this problem with toolchains already tested in the autobuilders. rtptools does not have any other dependencies, and we have a "basic" toolchain with no special options enabled.

Also, I think your patch should instead be:

select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

I already tried that and it didn't fix the problem. Also added to the .mk file the following:

ifeq ($(BR2_TOOLCHAIN_HAS_NATIVE_RPC),y)
RTPTOOLS_DEPENDENCIES += libtirpc
endif

After checking that libtirpc was installed, then I ran this command:

find output/staging/ -type f -name "ypclnt.h"

And that file doesn't exist either, so libtirpc can't fix the problem.

Regards,

Vincent.

Quoted 4 lines

and add libtirpc to the dependencies.

Thomas

#5 lore raw

PATCH 1/1 rtptools: needs RPC support

Hi again Thomas,

Quoted 20 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 17 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Vicente Olivert Riera
Quoted 2 lines

I'm surprised we have not seen autobuilder failures. Or did you forget to include a reference to an autobuilder error?

No, I didn't forget that. I have catch this issue with one local autobuilder I have. If you wonder why I have a local autobuilder instead of submitting the results to the ML, it's because that autobuilder uses toolchains that are not yet included in our Buildroot tree.

That's perfectly OK. However, I wonder why we haven't seen this problem with toolchains already tested in the autobuilders. rtptools does not have any other dependencies, and we have a "basic" toolchain with no special options enabled.

Quoted 8 lines
Quoted 3 lines

Also, I think your patch should instead be:

select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

I already tried that and it didn't fix the problem. Also added to the .mk file the following:

ifeq ($(BR2_TOOLCHAIN_HAS_NATIVE_RPC),y)

Sorry, I didn't put the "y" when I tried it. It was just a type while writing the email.

Regards,

Vincent.

Quoted 22 lines

RTPTOOLS_DEPENDENCIES += libtirpc
endif

After checking that libtirpc was installed, then I ran this command:

find output/staging/ -type f -name "ypclnt.h"

And that file doesn't exist either, so libtirpc can't fix the problem.

Regards,

Vincent.

Quoted 4 lines

and add libtirpc to the dependencies.

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#6 lore raw

PATCH 1/1 rtptools: needs RPC support

In reply to Vicente Olivert Riera
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

rtptools needs a toolchain with RPC support, otherwise it will fail with an error message like this one:

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */

Hmm, are you sure?

I just did a test build here with a toolchain without RPC support:

find output/staging/usr -name ypclnt.h

But it still built. I do see that rpctools itself contain that header file:

find output/build/rtptools-1.20 -name ypclnt.h output/build/rtptools-1.20/nt/include/ypclnt.h output/build/rtptools-1.20/nt/include/rpcsvc/ypclnt.h

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 rtptools: needs RPC support

Dear Peter Korsgaard,

Quoted 12 lines · Peter Korsgaard
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

rtptools needs a toolchain with RPC support, otherwise it will fail with an error message like this one:

host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */

Hmm, are you sure?

I just did a test build here with a toolchain without RPC support:

Quoted 9 lines

find output/staging/usr -name ypclnt.h

But it still built. I do see that rpctools itself contain that header file:

find output/build/rtptools-1.20 -name ypclnt.h output/build/rtptools-1.20/nt/include/ypclnt.h output/build/rtptools-1.20/nt/include/rpcsvc/ypclnt.h

We were discussing about this in the IRC during this afternoon, and checked that it actually builds with toolchains without RPC. I highlighted the issue using a toolchain which is a bit special. I then marked my patch as deferred few hours ago, but now I'm going to mark it as rejected. I will keep investigating about this because is very weird that the rtptools itself has the headers but my toolchain is not able to find them.

Regards,

Vincent.