Skip to contentSkip to conversation

ARM: dts: imx7d: Fix UART2 base address

PATCH New Fabio Estevam 4 participants 8 messages Sep 24, 2015 – Sep 30, 2015

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

---
 arch/arm/boot/dts/imx7d.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d.dtsi +2 -2
index 15c2193..9569d0a 100644
@@ -640,10 +640,10 @@
 				status = "disabled";
 			};
 
-			uart2: serial at 30870000 {
+			uart2: serial at 30890000 {
 				compatible = "fsl,imx7d-uart",
 					     "fsl,imx6q-uart";
-				reg = <0x30870000 0x10000>;
+				reg = <0x30890000 0x10000>;
 				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
 					<&clks IMX7D_UART2_ROOT_CLK>;
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

Frank, can you confirm it?

Shawn

Quoted 24 lines
---
 arch/arm/boot/dts/imx7d.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d.dtsi +2 -2
index 15c2193..9569d0a 100644
@@ -640,10 +640,10 @@
 				status = "disabled";
 			};
 
-			uart2: serial at 30870000 {
+			uart2: serial at 30890000 {
 				compatible = "fsl,imx7d-uart",
 					     "fsl,imx6q-uart";
-				reg = <0x30870000 0x10000>;
+				reg = <0x30890000 0x10000>;
 				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
 					<&clks IMX7D_UART2_ROOT_CLK>;
Signature · 1 line
1.9.1
author reviewer
#2 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

Hi Shawn,

Quoted 10 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

Frank, can you confirm it?

This patch uses the UART2 base address as stated in the MX7D Reference Manual.

It has also been tested on a custom board.

#3 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

Quoted 8 lines · Fabio Estevam

Hi Shawn,

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Fix it so that UART2 can be used.

Frank, can you confirm it?

This patch uses the UART2 base address as stated in the MX7D Reference Manual.

Is the Reference Manual published somewhere?

Shawn

author reviewer
#4 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

Hi Shawn,

Quoted 3 lines · Shawn Guo
Quoted 1 line

This patch uses the UART2 base address as stated in the MX7D Reference Manual.

Is the Reference Manual published somewhere?

It is not publicly available at this time

#5 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

In reply to Shawn Guo
Quoted 11 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

Frank, can you confirm it?

Shawn,
Yes, this change is correct. I confirmed in the SoC design db.

Quoted 23 lines

Shawn

Quoted 21 lines
---
 arch/arm/boot/dts/imx7d.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d.dtsi +2 -2
index 15c2193..9569d0a 100644
@@ -640,10 +640,10 @@
 				status = "disabled";
 			};
 
-			uart2: serial at 30870000 {
+			uart2: serial at 30890000 {
 				compatible = "fsl,imx7d-uart",
 					     "fsl,imx6q-uart";
-				reg = <0x30870000 0x10000>;
+				reg = <0x30890000 0x10000>;
 				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
 					<&clks IMX7D_UART2_ROOT_CLK>;
Quoted 9 lines
Quoted 3 lines
Signature · 1 line
1.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Regards,
Nitin

#6 lore raw

PATCH 1/1 ARM: dts: imx7d: Fix UART2 base address

Quoted 11 lines · Nitin Garg
Quoted 10 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

Frank, can you confirm it?

Yes, it is correct.

best regards
Frank Li

Quoted 44 lines
Quoted 1 line

Shawn,
Yes, this change is correct. I confirmed in the SoC design db.

Quoted 23 lines

Shawn

Quoted 21 lines
---
 arch/arm/boot/dts/imx7d.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d.dtsi +2 -2
index 15c2193..9569d0a 100644
@@ -640,10 +640,10 @@
                             status = "disabled";
                     };
 
-                    uart2: serial at 30870000 {
+                    uart2: serial at 30890000 {
                             compatible = "fsl,imx7d-uart",
                                          "fsl,imx6q-uart";
-                            reg = <0x30870000 0x10000>;
+                            reg = <0x30890000 0x10000>;
                             interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
                             clocks = <&clks IMX7D_UART2_ROOT_CLK>,
                                     <&clks IMX7D_UART2_ROOT_CLK>;
Quoted 9 lines
Quoted 3 lines

--
1.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Regards,
Nitin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel