mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
Andy Shevchenko
reviewerPATCH 1/1 mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
Jim Davis reported the compilation error with a random configuration which apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
--- drivers/mfd/intel-lpss.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/mfd/intel-lpss.h +2 -0
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); .thaw = intel_lpss_resume, \ .poweroff = intel_lpss_suspend, \ .restore = intel_lpss_resume, +#else +#define INTEL_LPSS_SLEEP_PM_OPS #endif #define INTEL_LPSS_RUNTIME_PM_OPS \
Signature · 1 line
2.5.1
Lee Jones
maintainerQuoted 9 lines · Andy Shevchenko
Jim Davis reported the compilation error with a random configuration which apparently has
CONFIG_PM=yandCONFIG_PM_SLEEP=n. With that conditions we have missed definition ofINTEL_LPSS_SLEEP_PM_OPSmacro. Add it here.Reported-by Jim Davis <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/intel-lpss.h | 2 ++ 1 file changed, 2 insertions(+)
Why are you using this email address?
Please use ./get_maintainer.pl properly.
Quoted 13 lines
drivers/mfd/intel-lpss.h +2
-0@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); .thaw = intel_lpss_resume, \ .poweroff = intel_lpss_suspend, \ .restore = intel_lpss_resume, +#else +#define INTEL_LPSS_SLEEP_PM_OPS #endif #define INTEL_LPSS_RUNTIME_PM_OPS \
Andy Shevchenko
reviewerQuoted 8 lines · Lee Jones
Quoted 6 lines · Andy Shevchenko
Jim Davis reported the compilation error with a random configuration which
apparently hasCONFIG_PM=yandCONFIG_PM_SLEEP=n. With that conditions we have
missed definition ofINTEL_LPSS_SLEEP_PM_OPSmacro. Add it here.
Quoted 7 lines
Quoted 5 lines
Reported-by Jim Davis <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/intel-lpss.h | 2 ++ 1 file changed, 2 insertions(+)Why are you using this email address?
In fact it *had* the proper address [1] and after you confused me [2].
[1] http://www.spinics.net/lists/kernel/msg2073973.html
[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html
Quoted 16 lines
Please use ./get_maintainer.pl properly.
Quoted 13 lines
drivers/mfd/intel-lpss.h +2
-0@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); .thaw = intel_lpss_resume, \ .poweroff = intel_lpss_suspend, \ .restore = intel_lpss_resume, +#else +#define INTEL_LPSS_SLEEP_PM_OPS #endif #define INTEL_LPSS_RUNTIME_PM_OPS \
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 15 lines · Andy Shevchenko
Quoted 14 lines · Lee Jones
Quoted 11 lines · Andy Shevchenko
Jim Davis reported the compilation error with a random configuration which
apparently hasCONFIG_PM=yandCONFIG_PM_SLEEP=n. With that conditions we have
missed definition ofINTEL_LPSS_SLEEP_PM_OPSmacro. Add it here.Reported-by Jim Davis <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/intel-lpss.h | 2 ++ 1 file changed, 2 insertions(+)
Quoted 5 lines
Quoted 1 line
Why are you using this email address?
In fact it *had* the proper address [1] and after you confused me [2].
This was the original patch submission, which was correct.
https://lkml.org/lkml/2015/10/1/484
However this email you sent to the wrong address.
Quoted 1 line
[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html
Then you followed up with a patch, also to the wrong address.
BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so.
Quoted 16 lines
Quoted 15 lines
Please use ./get_maintainer.pl properly.
Quoted 13 lines
drivers/mfd/intel-lpss.h +2
-0@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); .thaw = intel_lpss_resume, \ .poweroff = intel_lpss_suspend, \ .restore = intel_lpss_resume, +#else +#define INTEL_LPSS_SLEEP_PM_OPS #endif #define INTEL_LPSS_RUNTIME_PM_OPS \
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Andy Shevchenko
reviewerQuoted 3 lines · Lee Jones
Quoted 1 line
BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so.
Thanks!
P.S. I have got a message from kbuild bot that the bug is still there, though I noticed that the patch made at least linux-next tree.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy