Skip to contentSkip to conversation

mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP

PATCH In review Andy Shevchenko 3 participants 5 messages Oct 1, 2015 – Oct 5, 2015

Subsystems (2)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP

Jim Davis reported the compilation error with a random configuration which apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.

---
 drivers/mfd/intel-lpss.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/mfd/intel-lpss.h +2 -0
index f28cb28a..2c7f8d7 100644
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
 	.thaw = intel_lpss_resume,		\
 	.poweroff = intel_lpss_suspend,		\
 	.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
 #endif
 
 #define INTEL_LPSS_RUNTIME_PM_OPS		\
Signature · 1 line
2.5.1
maintainer
#1 lore raw
Quoted 9 lines · Andy Shevchenko

Jim Davis reported the compilation error with a random configuration which apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.

---
 drivers/mfd/intel-lpss.h | 2 ++
 1 file changed, 2 insertions(+)

Why are you using this email address?

Please use ./get_maintainer.pl properly.

Quoted 13 lines
drivers/mfd/intel-lpss.h +2 -0
index f28cb28a..2c7f8d7 100644
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
 	.thaw = intel_lpss_resume,		\
 	.poweroff = intel_lpss_suspend,		\
 	.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
 #endif
 
 #define INTEL_LPSS_RUNTIME_PM_OPS		\
author reviewer
#2 lore raw
Quoted 8 lines · Lee Jones
Quoted 6 lines · Andy Shevchenko

Jim Davis reported the compilation error with a random configuration which
apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.

Quoted 7 lines
Quoted 5 lines
---
 drivers/mfd/intel-lpss.h | 2 ++
 1 file changed, 2 insertions(+)

Why are you using this email address?

In fact it *had* the proper address [1] and after you confused me [2].

[1] http://www.spinics.net/lists/kernel/msg2073973.html
[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html

Quoted 16 lines

Please use ./get_maintainer.pl properly.

Quoted 13 lines
drivers/mfd/intel-lpss.h +2 -0
index f28cb28a..2c7f8d7 100644
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
 	.thaw = intel_lpss_resume,		\
 	.poweroff = intel_lpss_suspend,		\
 	.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
 #endif
 
 #define INTEL_LPSS_RUNTIME_PM_OPS		\
Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#3 lore raw
Quoted 15 lines · Andy Shevchenko
Quoted 14 lines · Lee Jones
Quoted 11 lines · Andy Shevchenko

Jim Davis reported the compilation error with a random configuration which
apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.

---
 drivers/mfd/intel-lpss.h | 2 ++
 1 file changed, 2 insertions(+)
Quoted 5 lines
Quoted 1 line

Why are you using this email address?

In fact it *had* the proper address [1] and after you confused me [2].

[1] http://www.spinics.net/lists/kernel/msg2073973.html

This was the original patch submission, which was correct.

https://lkml.org/lkml/2015/10/1/484

However this email you sent to the wrong address.

Quoted 1 line

[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html

Then you followed up with a patch, also to the wrong address.

BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so.

Quoted 16 lines
Quoted 15 lines

Please use ./get_maintainer.pl properly.

Quoted 13 lines
drivers/mfd/intel-lpss.h +2 -0
index f28cb28a..2c7f8d7 100644
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
 	.thaw = intel_lpss_resume,		\
 	.poweroff = intel_lpss_suspend,		\
 	.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
 #endif
 
 #define INTEL_LPSS_RUNTIME_PM_OPS		\
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author reviewer
#4 lore raw
Quoted 3 lines · Lee Jones
Quoted 1 line

BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so.

Thanks!

P.S. I have got a message from kbuild bot that the bug is still there, though I noticed that the patch made at least linux-next tree.

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy