linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
PATCH v3 1/1 linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
--- recipes-kernel/linux/linux-raspberrypi.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
@@ -12,7 +12,8 @@ SRC_URI += " \ COMPATIBLE_MACHINE = "raspberrypi" -PV = "${LINUX_VERSION}+git${SRCREV}" +PE = "1" +PV = "${LINUX_VERSION}+git${SRCPV}" # NOTE: For now we pull in the default config from the RPi kernel GIT tree. KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
Signature · 1 line
2.6.0
Quoted 12 lines · Jonathan Liu
SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-kernel/linux/linux-raspberrypi.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)recipes-kernel/linux/linux-raspberrypi.inc +0
-0
recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 17
Quoted 7 lines
recipes-kernel/linux/linux-raspberrypi.inc +2
-1@@ -12,7 +12,8 @@ SRC_URI += " \ COMPATIBLE_MACHINE = "raspberrypi" -PV = "${LINUX_VERSION}+git${SRCREV}" +PE = "1" +PV = "${LINUX_VERSION}+git${SRCPV}"
Doesn't PRServer takes care for things like these?
Andreas
Quoted 16 lines · Andreas Müller
Quoted 15 lines · Jonathan Liu
SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-kernel/linux/linux-raspberrypi.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)recipes-kernel/linux/linux-raspberrypi.inc +0
-0@@ -12,7 +12,8 @@ SRC_URI += " \ COMPATIBLE_MACHINE = "raspberrypi"
Quoted 7 lines
recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 17
Quoted 4 lines
recipes-kernel/linux/linux-raspberrypi.inc +2
-1-PV = "${LINUX_VERSION}+git${SRCREV}" +PE = "1" +PV = "${LINUX_VERSION}+git${SRCPV}"Doesn't PRServer takes care for things like these?
Andreas
The version goes backwards because the the revision is shortened. It does rebuild the package though when the version changes because of PRServer but it breaks package feeds when the version goes backwards. Upgrading using package manager on the target device would not detect a newer version.
Regards,
Jonathan
Quoted 22 lines · Jonathan Liu
SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
Signed-off-by Jonathan Liu <[email protected]>--- recipes-kernel/linux/linux-raspberrypi.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)recipes-kernel/linux/linux-raspberrypi.inc +2
-2@@ -12,7 +12,8 @@ SRC_URI += " \ COMPATIBLE_MACHINE = "raspberrypi" -PV = "${LINUX_VERSION}+git${SRCREV}" +PE = "1" +PV = "${LINUX_VERSION}+git${SRCPV}" # NOTE: For now we pull in the default config from the RPi kernel GIT tree. KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig" --
Quoted 2 lines
2.6.0
I tested build locally and based on your comments on PE I merged this patch.
Thanks,
--
Andrei Gherzan