Skip to contentSkip to conversation

fixup! virtio: introduce virtio_map

PATCH In review Michael S. Tsirkin 2 participants 2 messages Oct 27, 2015

lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

PATCH 1/1 fixup! virtio: introduce virtio_map

---

This will fix the issue reported by Cornelia.

 hw/virtio/virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/virtio.c +1 -1
index be32145..ed1f274 100644
@@ -449,7 +449,7 @@ int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
 }
 
 static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr,
-                                size_t *num_sg, size_t max_size,
+                                unsigned int *num_sg, unsigned int max_size,
                                 int is_write)
 {
     unsigned int i;
Signature · 1 line
MST
#1 lore raw
Quoted 12 lines · On Tue, 27 Oct 2015 14:30:05 +0200 "Michael S. Tsirkin" <[email protected]> wrote:

---

This will fix the issue reported by Cornelia.

 hw/virtio/virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/virtio.c +0 -0
index be32145..ed1f274 100644

hw/virtio/virtio.c int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes, · line 455

Quoted 8 lines
hw/virtio/virtio.c +1 -1
@@ -449,7 +449,7 @@ int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
 }
 
 static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr,
-                                size_t *num_sg, size_t max_size,
+                                unsigned int *num_sg, unsigned int max_size,
                                 int is_write)
 {
     unsigned int i;

With this fixup applied, both s390 machines come up. virtio-serial and virtio-blk with and without dataplane seem fine.

At a first glance, the code seems fine as well.