Skip to contentSkip to conversation

clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

PATCH Superseded Mutharaju, Prasanna (P.) 2 participants 3 messages Nov 30, 2015

Subsystems (3)
Common clk Arm Samsung Exynos Samsung SoC clock drivers

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Mutharaju, Prasanna (P.)

author
#0 lore raw

PATCH v2 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

From: Prasanna Karthik <[email protected]>

Remove unneeded variable used to store return value.
V2: Modified subject

Signed-off-by Prasanna Karthik <[email protected]>
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

Quoted 4 lines · Prasanna (P.)

From: Prasanna Karthik <[email protected]>

Remove unneeded variable used to store return value.
V2: Modified subject

Changelog (v2) should go after '---' separator so it won't get included in the commit message.

Now I see that you Signed-off-by is okay - same email address... I got confused by the difference in name.

Best regards,
Krzysztof

Quoted 25 lines
Signed-off-by Prasanna Karthik <[email protected]>
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {
author
#2 lore raw

PATCH v2 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

Quoted 9 lines · Krzysztof Kozlowski
Quoted 4 lines · Prasanna (P.)

From: Prasanna Karthik <[email protected]>

Remove unneeded variable used to store return value.
V2: Modified subject

Changelog (v2) should go after '---' separator so it won't get included in the commit message.

Done in v3.

Quoted 2 lines

Now I see that you Signed-off-by is okay - same email address... I got confused by the difference in name.

Yeah, my gitconfig and outlook account differ little.

Quoted 28 lines

Best regards,
Krzysztof

Quoted 25 lines
Signed-off-by Prasanna Karthik <[email protected]>
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {