clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
Subsystems (3)
PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
From: Prasanna Karthik <[email protected]>
Remove unneeded variable used to store return value.
---
v3: Modified subject and changelog comments
---
--- drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)static int s3c24xx_clkout_set_parent (struct clk_hw *hw,u8 index) {struct s3c24xx_clkout *clkout =to_s3c24xx_clkout (hw); -int ret =0 ;s3c2410_modify_misccr ((clkout->mask << clkout->shift), (index << clkout->shift)); -return ret; +return 0 ; }static const struct clk_ops s3c24xx_clkout_ops = {
Signature · 1 line
1.9.1
PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
Quoted 8 lines · Prasanna (P.)
From: Prasanna Karthik <[email protected]>
Remove unneeded variable used to store return value.
---
v3: Modified subject and changelog comments
---Signed-off-by Prasanna Karthik <[email protected]>
... and now download the patch and try to apply it with "git am". What is missing? :)
Best regards,
Krzysztof
Quoted 23 lines
--- drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/clk/samsung/clk-s3c2410-dclk.c +1
-2@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)static int s3c24xx_clkout_set_parent (struct clk_hw *hw,u8 index) {struct s3c24xx_clkout *clkout =to_s3c24xx_clkout (hw); -int ret =0 ;s3c2410_modify_misccr ((clkout->mask << clkout->shift), (index << clkout->shift)); -return ret; +return 0 ; }static const struct clk_ops s3c24xx_clkout_ops = {
PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
In reply to Mutharaju, Prasanna (P.)Quoted 8 lines · Prasanna (P.)
From: Prasanna Karthik <[email protected]>
Remove unneeded variable used to store return value.
---
v3: Modified subject and changelog comments
---Signed-off-by Prasanna Karthik <[email protected]>
Everything after the first triple-dash doesn't make it into the git history, so you are expected to write the S-o-b line above the list of things changed since a previous submission.
Other than that the patch looks fine.
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v3 1/1 clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
Quoted 8 lines · Uwe Kleine-K?nig
Quoted 7 lines · Prasanna (P.)
From: Prasanna Karthik <[email protected]>
Remove unneeded variable used to store return value.
---
v3: Modified subject and changelog comments
---
Quoted 5 lines
Quoted 1 line
Signed-off-by Prasanna Karthik <[email protected]>Everything after the first triple-dash doesn't make it into the git history, so you are expected to write the S-o-b line above the list of things changed since a previous submission.
Thanks, I resent the patch again with S-o-b before changelog.
Quoted 8 lines
Other than that the patch looks fine.
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |