Skip to contentSkip to conversation

Staging: iio: accel: Fixed NULL comparison style

PATCH Superseded Bhaktipriya Shridhar 2 participants 2 messages Dec 13, 2015

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: iio: accel: Fixed NULL comparison style

The variable u8 **rx_p, is a pointer-to-pointer and hence the check should be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which was buggy:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {

---
Changes in v2:

        -Replaced "if (!rx_p)" with "if (!*rx_p)"
 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_ring.c +1 -1
index 5339b10..1920dc60 100644
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (!rx_p) {
+	if (!*rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}
Signature · 1 line
2.1.4
#1 lore raw

You have to resend it to apply on the original code, we are not going to apply the first version of this patch. In other words it is:

- if (*rx_p == NULL) {
+ if (!*rxp) {

regards,
dan carpenter