Skip to contentSkip to conversation

Staging: iio: accel: Fixed NULL comparison style

PATCH Applied Bhaktipriya Shridhar 2 participants 2 messages Dec 13, 2015 – Dec 19, 2015

Subsystems (3)
Staging IIO Staging - industrial io
lore
Share & tools
lore

Bhaktipriya Shridhar

author
#0 lore raw

PATCH v3 1/1 Staging: iio: accel: Fixed NULL comparison style

The variable u8 **rx_p, is a pointer-to-pointer and hence the check should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which was incorrect:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {

Signed-off-by Bhaktipriya Shridhar <[email protected]>

---
Changes in v3:
- Replaced "if (!rx_p)" with "if (!*rx_p)"
- Changes are made on the original code

 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_ring.c +1 -1
index 20b878d..1920dc60 100644
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (*rx_p == NULL) {
+	if (!*rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}
Signature · 1 line
2.1.4
maintainer Applied
#1 lore raw
Quoted 9 lines · Bhaktipriya Shridhar

The variable u8 **rx_p, is a pointer-to-pointer and hence the check should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which was incorrect:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {

Signed-off-by Bhaktipriya Shridhar <[email protected]>

Applied to the togreg branch of iio.git with the addition of the driver name in the patch title.

Thanks

Jonathan

Quoted 22 lines

---
Changes in v3:
- Replaced "if (!rx_p)" with "if (!*rx_p)"
- Changes are made on the original code

 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_ring.c +1 -1
index 20b878d..1920dc60 100644
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (*rx_p == NULL) {
+	if (!*rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}